Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #560

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix CI #560

merged 2 commits into from
Apr 4, 2023

Conversation

hra687261
Copy link
Contributor

No description provided.

@hra687261 hra687261 changed the title attempt to fix the JS build [WIP] attempt to fix the CI Apr 3, 2023
@hra687261 hra687261 marked this pull request as draft April 3, 2023 10:56
@Halbaroth Halbaroth added this to the 2.6.0 milestone Apr 3, 2023
@Halbaroth
Copy link
Collaborator

Halbaroth commented Apr 3, 2023 •
edited
Loading

I can reproduce the error using the same version of OCaml (4.10.0) and js_of_ocaml (5.1.1). The error disappears with js_of_ocaml 5.0.1.

A short guideline for this kind of problem with js_of_ocaml:

  1. Update your opam list: opam update
  2. Create a local opam switch and install the same version of OCaml and js_of_ocaml
  3. Try to reproduce the error with this switch
  4. If it doesn't work... you can pray
  5. If it works, downgrade js_of_ocaml until the error message disappears

@hra687261
Copy link
Contributor Author

That seems correct, thanks!
This will need a real fix at some point, but for now I think it's safe to set an upper bound for js_of_ocaml.
Also the version of ocaml that is used for the CI can/should probably be increased to something like 4.12.0.

@hra687261 hra687261 marked this pull request as ready for review April 4, 2023 01:22
@hra687261 hra687261 changed the title [WIP] attempt to fix the CI Fix CI Apr 4, 2023
@Halbaroth Halbaroth merged commit b0cb9a7 into OCamlPro:next Apr 4, 2023
Halbaroth pushed a commit to Halbaroth/alt-ergo that referenced this pull request Apr 15, 2023
@hra687261 @Halbaroth
Fix CI (OCamlPro#560)
06ae5da 
* JS: add missing primitives

* Set upper bound 5.0.1 for js_of_ocaml
Halbaroth added a commit that referenced this pull request Apr 17, 2023
@Halbaroth @hra687261
Fix ci 2.4.3 (#575)
8e420c4 
* CI: avsm/setup-ocaml@v2 -> ocaml/setup-ocaml@v2

* Fix CI: (#525)

- Replaced `ocaml-version` with `ocaml-compiler`
- Switched to `actions/checkout@v3`

* Fix js of ocaml (#542)

* Upgrade to js_of_ocaml 5

* Fix the makefile for the js target

* Simplify dune file

* Require dune 2.8+

* Fix CI (#560)

* JS: add missing primitives

* Set upper bound 5.0.1 for js_of_ocaml

---------

Co-authored-by: hra687261 <hra687261@gmail.com>
@hra687261 hra687261 deleted the fix-ci branch June 11, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Halbaroth Halbaroth Halbaroth approved these changes

Assignees
No one assigned
Labels
bug build
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hra687261 @Halbaroth