Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci 2.4.3 #575

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Fix ci 2.4.3 #575

merged 4 commits into from
Apr 17, 2023

Conversation

Halbaroth
Copy link
Collaborator

No description provided.

hra687261 and others added 3 commits April 14, 2023 18:21
- Replaced `ocaml-version` with `ocaml-compiler`
- Switched to `actions/checkout@v3`
* Upgrade to js_of_ocaml 5

* Fix the makefile for the js target

* Simplify dune file

* Require dune 2.8+
* JS: add missing primitives

* Set upper bound 5.0.1 for js_of_ocaml
@Halbaroth Halbaroth marked this pull request as ready for review April 17, 2023 06:32
Copy link
Collaborator

@bclement-ocp bclement-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Halbaroth Halbaroth merged commit 8e420c4 into OCamlPro:2.4.x Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants