Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci improvements #110

Closed
wants to merge 9 commits into from
Closed

Conversation

muraca
Copy link
Collaborator

@muraca muraca commented Oct 3, 2023

• renamed build.yml to ci.yml
• use toml-sort action, removed toml-sort.yml
• removed check
• test with nextest, llvm cov for coverage ~ fixes #106
• added --no-deps to clippy
• bumped version for updated actions
• removed unmantained actions
⚠️ @JoshOrndorff ⚠️ tests and clippy start only after rustfmt and toml sort are successful, this is intentional and I would like to keep it

• renamed build.yml to ci.yml
• use toml-sort action, removed toml-sort.yml
• removed check
• test with nextest, llvm cov for coverage

Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
@muraca muraca self-assigned this Oct 3, 2023
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I left a few questions but I trust your judgement.

rust-toolchain.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@muraca
Copy link
Collaborator Author

muraca commented Oct 4, 2023

@JoshOrndorff please set Workflow permissions to read and write in Settings > Actions > General.

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Oct 4, 2023

For some reason, that option is disabled for me.

EDIT: Okay, I did it at the organization level and restarted the job.

According to https://docs.github.com/en/actions/security-guides/automatic-token-authentication#example-1-passing-the-github_token-as-an-input it looks like how you did pull_requests: write should work.

Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
@muraca
Copy link
Collaborator Author

muraca commented Oct 4, 2023

The problem is that the action is performed on my fork, and the bot is trying to comment on this repo using the secret key of my personal repo. This does not happen if the branch is part of this repo, see #112 or muraca#2 . Looks like there's nothing we can do to avoid it, so I'll try to run the step only if the repo of the head and the base are the same, otherwise print it in the action output

Signed-off-by: muraca <mmuraca247@gmail.com>
@muraca
Copy link
Collaborator Author

muraca commented Oct 4, 2023

@JoshOrndorff
Copy link
Contributor

So this is the one you want to merge, right?

Go ahead and merge the one you when you're ready, and close the other one.

Is it possible to print the results to terminal in both cases? (And also comment when possible?) If not no big deal.

@JoshOrndorff JoshOrndorff mentioned this pull request Oct 5, 2023
@muraca
Copy link
Collaborator Author

muraca commented Oct 5, 2023

Is it possible to print the results to terminal in both cases? (And also comment when possible?)

yes, I am going to test it out right now.

Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
@muraca
Copy link
Collaborator Author

muraca commented Oct 5, 2023

#112

@muraca muraca closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage in CI
2 participants