-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci improvements #110
Ci improvements #110
Conversation
• renamed build.yml to ci.yml • use toml-sort action, removed toml-sort.yml • removed check • test with nextest, llvm cov for coverage Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I left a few questions but I trust your judgement.
@JoshOrndorff please set Workflow permissions to read and write in Settings > Actions > General. |
EDIT: Okay, I did it at the organization level and restarted the job. According to https://docs.github.com/en/actions/security-guides/automatic-token-authentication#example-1-passing-the-github_token-as-an-input it looks like how you did |
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
The problem is that the action is performed on my fork, and the bot is trying to comment on this repo using the secret key of my personal repo. This does not happen if the branch is part of this repo, see #112 or muraca#2 . Looks like there's nothing we can do to avoid it, so I'll try to run the step only if the repo of the head and the base are the same, otherwise print it in the action output |
Signed-off-by: muraca <mmuraca247@gmail.com>
ed32dda
to
574b52c
Compare
@JoshOrndorff please take a look at this https://github.com/Off-Narrative-Labs/Tuxedo/actions/runs/6411679096/job/17407615977?pr=110 |
So this is the one you want to merge, right? Go ahead and merge the one you when you're ready, and close the other one. Is it possible to print the results to terminal in both cases? (And also comment when possible?) If not no big deal. |
yes, I am going to test it out right now. |
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
• renamed build.yml to ci.yml⚠️ @JoshOrndorff ⚠️ tests and clippy start only after rustfmt and toml sort are successful, this is intentional and I would like to keep it
• use toml-sort action, removed toml-sort.yml
• removed check
• test with nextest, llvm cov for coverage ~ fixes #106
• added --no-deps to clippy
• bumped version for updated actions
• removed unmantained actions
•