Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements #112

Merged
merged 2 commits into from
Oct 5, 2023
Merged

CI Improvements #112

merged 2 commits into from
Oct 5, 2023

Conversation

muraca
Copy link
Collaborator

@muraca muraca commented Oct 4, 2023

  • renamed build.yml to ci.yml
  • use toml-sort action in ci.yml
  • removed toml-sort.yml
  • removed cargo check job
  • perform tests with nextest instead of cargo test
  • added llvm cov for coverage ~ fixes Code Coverage in CI #106
  • print lines coverage to actions cli output
  • comment PR with report when allowed
  • added --no-deps arg to clippy
  • bumped version for upgraded actions
  • removed unmaintained actions
  • created rust-toolchain.toml with stable channel
  • tests and clippy are run after rustfmt and toml-sort are successful
  • tests and clippy's target is cached even on failure

- renamed `build.yml` to `ci.yml`
- use toml-sort action in `ci.yml`
- removed `toml-sort.yml`
- removed cargo check job
- perform tests with nextest instead of cargo test
- added llvm cov for coverage ~ fixes #106
- added `--no-deps` arg to clippy
- bumped version for upgraded actions
- removed unmaintained actions
- created `rust-toolchain.toml` with stable channel
- tests and clippy are run after rustfmt and toml-sort are successful
- tests and clippy's target is cached even on failure

Signed-off-by: muraca <mmuraca247@gmail.com>
@muraca muraca self-assigned this Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Coverage after merging ci-improvements into main

62.29%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
tuxedo-core/aggregator/src
   lib.rs98.65%100%100%98.55%102, 21
tuxedo-core/no_bound/src
   clone_no_bound.rs36.63%100%30%37.36%24, 32–39, 56, 59–72, 74–87, 89, 91–95, 98–99
   debug_no_bound.rs32.73%100%30%33%101–105, 108–109, 24, 32–42, 58, 60–78, 80–95, 97–99
   default_no_bound.rs0%100%0%0%100–122, 124–131, 133, 136–147, 151–157, 161–171, 23–24, 26–28, 30–39, 41–48, 51, 54–80, 83–88, 91–99
   lib.rs66.67%100%66.67%66.67%25–27
tuxedo-core/src
   constraint_checker.rs84.72%100%70.59%89.09%94
   dynamic_typing.rs84.03%100%72.73%88.37%57, 59
   executive.rs96.41%100%96.23%96.43%108, 163, 195, 210–218, 226, 237, 288, 301, 352–357, 359, 368–370, 372–373
   types.rs60.29%100%50%64.58%112, 114, 13, 144, 15, 37, 39, 74, 76–79, 81–87
   utxo_set.rs90.91%100%100%88.89%39–40
   verifier.rs85.86%100%67.95%90.35%108, 142, 28, 30, 46–48, 60, 62, 78
tuxedo-template-runtime/src
   lib.rs29.33%100%20.27%30.82%100–105, 107, 194, 196, 199, 204–206, 216–218, 220, 222, 224, 226, 228, 230, 232, 234, 237, 242–243, 251–272, 275–302, 305–418, 64–69
wallet/src
   amoeba.rs0%100%0%0%100–106, 109–110, 112–118, 120–127, 19–48, 51–52, 54–99
   cli.rs0%100%0%0%110, 117, 14, 17, 19, 32, 39, 50, 61, 83, 94, 99
   keystore.rs0%100%0%0%32–34, 39–46, 48–49, 52, 54–60, 66–74, 77–79, 81–83, 86–92, 94–95
   main.rs0%100%0%0%100, 102–103, 106–118, 121, 123–127, 130–134, 136–145, 147–148, 152–162, 165–166, 168, 171–172, 179–185, 187–190, 192–193, 196–203, 206–209, 211–213, 216–218, 220, 222, 225–238, 241–244, 246–257, 259, 34–43, 46, 49, 53, 56–62, 65, 67–69, 74–77, 79, 81, 83–84, 87–88, 90, 92–94, 99
   money.rs0%100%0%0%100–101, 105, 109–112, 114, 119–125, 127–131, 134–135, 139–144, 146–147, 22–28, 31–49, 53–59, 65–72, 74, 78–83, 87, 90, 92, 95–98
   output_filter.rs100%100%100%100%
   rpc.rs0%100%0%0%10–14, 17–19, 21, 23–26, 9
   sync.rs0%100%0%0%100–101, 107–111, 115, 118–119, 122, 124–138, 143–147, 149–150, 155–160, 164–167, 174–175, 177, 180–183, 188–190, 193–194, 197–202, 204–206, 209, 211–212, 217–220, 223–224, 231–235, 237–243, 246–248, 250–251, 254–255, 260–263, 266, 268–269, 274–277, 280, 282–283, 286–292, 294–295, 298–299, 302–303, 306–307, 311–317, 320–324, 327–329, 332–340, 342, 346, 348–349, 352–353, 356–363, 365–366, 369–370, 372, 374–375, 379–381, 383–384, 386–387, 389–390, 393–395, 397–398, 400–401, 403–404, 408, 410–411, 415, 417–422, 425–426, 429–431, 434, 437–440, 442, 445–448, 451, 454–455, 458–459, 46, 464–469, 47, 471, 473, 478–479, 48, 480–481, 484–485, 488–489, 49, 490–493, 495, 498–499, 50, 503–504, 506, 508–509, 51, 510, 512–515, 518–519, 52–56, 58–66, 68, 70–76, 78, 80, 82, 84–86, 91–94, 96
wardrobe/amoeba/src
   lib.rs58.17%100%26.83%69.64%124, 142–144, 182–184, 27, 83–85
   tests.rs100%100%100%100%
wardrobe/kitties/src
   lib.rs53.16%100%29.66%63.74%102, 105, 107, 109, 111, 113, 115, 117, 119, 121, 123, 125, 127, 129, 131, 133, 135, 137, 139, 268, 300, 303, 363, 38–40, 42, 44, 50, 52, 58, 60, 66–68, 71, 75, 77, 99
   tests.rs99.61%100%98.25%99.78%
wardrobe/money/src
   lib.rs39.86%100%14.58%52%140, 22–24, 32–35, 39, 47, 52–54, 62, 65, 68, 70, 72, 76, 79, 82
   tests.rs100%100%100%100%
wardrobe/poe/src
   lib.rs0%100%0%0%100–102, 110–119, 123–124, 130–132, 137–146, 150–154, 156–157, 170–172, 177–183, 40–41, 54–55, 58, 60, 62, 64, 68, 86–88, 93–99
wardrobe/runtime_upgrade/src
   lib.rs0%100%0%0%103–105, 107–113, 117–121, 32–33, 35, 43, 71–74, 80–89, 91–99

@muraca muraca mentioned this pull request Oct 4, 2023
@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Oct 5, 2023

This PR demonstrated that the code coverage comment works when the PR is from this same repo. Now we know.

I'm closing this because I believe you intend to merge #110 right? If I misunderstood, feel free to re-open this one.

@muraca muraca reopened this Oct 5, 2023
- print lines coverage to actions cli output
- comment PR with report when allowed

Signed-off-by: muraca <mmuraca247@gmail.com>
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Coverage after merging ci-improvements into main

62.29%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
tuxedo-core/aggregator/src
   lib.rs98.65%100%100%98.55%102, 21
tuxedo-core/no_bound/src
   clone_no_bound.rs36.63%100%30%37.36%24, 32–39, 56, 59–72, 74–87, 89, 91–95, 98–99
   debug_no_bound.rs32.73%100%30%33%101–105, 108–109, 24, 32–42, 58, 60–78, 80–95, 97–99
   default_no_bound.rs0%100%0%0%100–122, 124–131, 133, 136–147, 151–157, 161–171, 23–24, 26–28, 30–39, 41–48, 51, 54–80, 83–88, 91–99
   lib.rs66.67%100%66.67%66.67%25–27
tuxedo-core/src
   constraint_checker.rs84.72%100%70.59%89.09%94
   dynamic_typing.rs84.03%100%72.73%88.37%57, 59
   executive.rs96.41%100%96.23%96.43%108, 163, 195, 210–218, 226, 237, 288, 301, 352–357, 359, 368–370, 372–373
   types.rs60.29%100%50%64.58%113, 115, 13, 145, 15, 37, 39, 75, 77–80, 82–88
   utxo_set.rs90.91%100%100%88.89%39–40
   verifier.rs85.86%100%67.95%90.35%108, 142, 28, 30, 46–48, 60, 62, 78
tuxedo-template-runtime/src
   lib.rs29.33%100%20.27%30.82%100–105, 107, 194, 196, 199, 204–206, 216–218, 220, 222, 224, 226, 228, 230, 232, 234, 237, 242–243, 251–272, 275–302, 305–418, 64–69
wallet/src
   amoeba.rs0%100%0%0%100–106, 109–110, 112–118, 120–127, 19–48, 51–52, 54–99
   cli.rs0%100%0%0%110, 117, 14, 17, 19, 32, 39, 50, 61, 83, 94, 99
   keystore.rs0%100%0%0%32–34, 39–46, 48–49, 52, 54–60, 66–74, 77–79, 81–83, 86–92, 94–95
   main.rs0%100%0%0%100, 102–103, 106–118, 121, 123–127, 130–134, 136–145, 147–148, 152–162, 165–166, 168, 171–172, 179–185, 187–190, 192–193, 196–203, 206–209, 211–213, 216–218, 220, 222, 225–238, 241–244, 246–257, 259, 34–43, 46, 49, 53, 56–62, 65, 67–69, 74–77, 79, 81, 83–84, 87–88, 90, 92–94, 99
   money.rs0%100%0%0%100–101, 105, 109–112, 114, 119–125, 127–131, 134–135, 139–144, 146–147, 22–28, 31–49, 53–59, 65–72, 74, 78–83, 87, 90, 92, 95–98
   output_filter.rs100%100%100%100%
   rpc.rs0%100%0%0%10–14, 17–19, 21, 23–26, 9
   sync.rs0%100%0%0%100–101, 107–111, 115, 118–119, 122, 124–138, 143–147, 149–150, 155–160, 164–167, 174–175, 177, 180–183, 188–190, 193–194, 197–202, 204–206, 209, 211–212, 217–220, 223–224, 231–235, 237–243, 246–248, 250–251, 254–255, 260–263, 266, 268–269, 274–277, 280, 282–283, 286–292, 294–295, 298–299, 302–303, 306–307, 311–317, 320–324, 327–329, 332–340, 342, 346, 348–349, 352–353, 356–363, 365–366, 369–370, 372, 374–375, 379–381, 383–384, 386–387, 389–390, 393–395, 397–398, 400–401, 403–404, 408, 410–411, 415, 417–422, 425–426, 429–431, 434, 437–440, 442, 445–448, 451, 454–455, 458–459, 46, 464–469, 47, 471, 473, 478–479, 48, 480–481, 484–485, 488–489, 49, 490–493, 495, 498–499, 50, 503–504, 506, 508–509, 51, 510, 512–515, 518–519, 52–56, 58–66, 68, 70–76, 78, 80, 82, 84–86, 91–94, 96
wardrobe/amoeba/src
   lib.rs58.17%100%26.83%69.64%124, 142–144, 182–184, 27, 83–85
   tests.rs100%100%100%100%
wardrobe/kitties/src
   lib.rs53.16%100%29.66%63.74%102, 105, 107, 109, 111, 113, 115, 117, 119, 121, 123, 125, 127, 129, 131, 133, 135, 137, 139, 268, 300, 303, 363, 38–40, 42, 44, 50, 52, 58, 60, 66–68, 71, 75, 77, 99
   tests.rs99.61%100%98.25%99.78%
wardrobe/money/src
   lib.rs39.86%100%14.58%52%140, 22–24, 32–35, 39, 47, 52–54, 62, 65, 68, 70, 72, 76, 79, 82
   tests.rs100%100%100%100%
wardrobe/poe/src
   lib.rs0%100%0%0%100–102, 110–119, 123–124, 130–132, 137–146, 150–154, 156–157, 170–172, 177–183, 40–41, 54–55, 58, 60, 62, 64, 68, 86–88, 93–99
wardrobe/runtime_upgrade/src
   lib.rs0%100%0%0%103–105, 107–113, 117–121, 32–33, 35, 43, 71–74, 80–89, 91–99

@muraca muraca merged commit b86ed18 into main Oct 5, 2023
5 checks passed
@muraca muraca deleted the ci-improvements branch October 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage in CI
2 participants