-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Improvements #112
Merged
Merged
CI Improvements #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed `build.yml` to `ci.yml` - use toml-sort action in `ci.yml` - removed `toml-sort.yml` - removed cargo check job - perform tests with nextest instead of cargo test - added llvm cov for coverage ~ fixes #106 - added `--no-deps` arg to clippy - bumped version for upgraded actions - removed unmaintained actions - created `rust-toolchain.toml` with stable channel - tests and clippy are run after rustfmt and toml-sort are successful - tests and clippy's target is cached even on failure Signed-off-by: muraca <mmuraca247@gmail.com>
Closed
This PR demonstrated that the code coverage comment works when the PR is from this same repo. Now we know. I'm closing this because I believe you intend to merge #110 right? If I misunderstood, feel free to re-open this one. |
- print lines coverage to actions cli output - comment PR with report when allowed Signed-off-by: muraca <mmuraca247@gmail.com>
muraca
force-pushed
the
ci-improvements
branch
from
October 5, 2023 18:19
fa3f14b
to
3f290c9
Compare
Coverage after merging ci-improvements into main
Coverage Report
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.yml
toci.yml
ci.yml
toml-sort.yml
--no-deps
arg to clippyrust-toolchain.toml
with stable channel