Fixed array_keys(null) and call to undefined method in Mage_Eav_Model_Config

[F1Red5]

Description (*)

Issue 1: array_keys(null) fixed arround line 573.

Issue 2: undifiened method getDefaultAttributes() for invoice, creditmemo, ... fixed arround line 372

Related Pull Requests

1. See EAV Config Cache #2993

Fixed Issues (if relevant)

1. See N98-magerun tests fails since #2993 #4034

Manual testing scenarios (*)

1. install n98/magerun:dev-develop (v3.0.0)
2. add custom attributes to all entity types

Test script

<?php

require_once('app/Mage.php');
umask(0);
Mage::app();

class Test4034
{
  public function prepare()
  {
      $attributeCode = 'crazyCoolAttribute';
      $data = ['type'  => 'text', 'input' => 'text', 'label' => 'Test Attribute'];

      foreach (self::entityTypeProvider() as $entityType) {
          $this->createAttribute(array_values($entityType)[0], $attributeCode, $data);
      }
  }

  /**
   * From N98-magerun unit test
   */
  public static function entityTypeProvider()
  {
      return [['catalog_category'], ['catalog_product'], ['creditmemo'], ['customer'], ['customer_address'], ['invoice'], ['order'], ['shipment']];
  }

  /**
   * From N98-magerun unit test
   *
   * @param string $entityType
   * @param string $attributeCode
   * @param array $data
   */
  protected function createAttribute($entityType, $attributeCode, $data)
  {
      $setup = Mage::getModel('eav/entity_setup', 'core_setup');
      $setup->addAttribute($entityType, $attributeCode, $data);
  }
}

$test = new Test4034();
$test->prepare();

3. test eav:attribute:view creditmemo crazyCoolAttribute and eav:attribute:remove creditmemo crazyCoolAttribute

Questions or comments

After adding/removing EAV cache has to be cleaned, but this should be done in N98-magerun. (???) Not sure if it fixes all errors in unit tests, but these two issues should be easy to reproduce.

Todo: add Mage::app()->getCacheInstance()->cleanType('eav');

[kiatng]

I don't get this:

test eav:attribute:view creditmemo crazyCoolAttribute and eav:attribute:remove creditmemo crazyCoolAttribute

How to test the above?

[fballiano]

I guess it's n98-magerun eav:attribute:view creditmemo crazyCoolAttribute

[fballiano]

magerun build doesn't work on mac and I can't find any doc, I'll blindly review this PR

[fballiano]

I don't see any problem in merging these minor changes so I'll do