Fixed undefined array key in Mage/Eav/Model/Config.php #4059
Conversation
| @@ -571,7 +571,9 @@ public function getEntityAttributeCodes($entityType, $object = null) | |||
| } | |||
| return $attributeCodes; | |||
| } else { | |||
| return array_keys($this->_entityTypeAttributeIdByCode[$storeId][$entityType->getId()]); | |||
| return isset($this->_entityTypeAttributeIdByCode[$storeId][$entityType->getId()]) | |||
There was a problem hiding this comment.
Wouldnt return array_keys($this->_entityTypeAttributeIdByCode[$storeId][$entityType->getId()] ?? []) do the same?
There was a problem hiding this comment.
Changing array_keys to isset changes the return of the function which is supposed to return attribute codes, not a boolean value.
There was a problem hiding this comment.
@davidhiendl It doesnt return boolean. I think you read that wrong. :)
There was a problem hiding this comment.
Yeah that code comment snippet function did cut of mid-change... fabulous.
There was a problem hiding this comment.
@pquerner I think array_keys($this->_entityTypeAttributeIdByCode[$storeId][$entityType->getId()] ?? []) would still trigged the undefined array index warning
There was a problem hiding this comment.
@fballiano https://onlinephp.io/c/eebcc nope, unless I did something wrong.
There was a problem hiding this comment.
array_keys($this->_entityTypeAttributeIdByCode[$storeId][$entityType->getId()] ?? []) works but not necessary better.
My break down:
- The null coalescing operator (??) doc is here.
$result = $array['a'] ?? []is the same as$result = isset($array['a']) ? $array['a'] : [] - after the above, we have
array_kyes($result), an additional step if key 'a' is not set.
This isset($array['a']) ? array_keys($array['a']) : [] works slightly better if key 'a' is not set. However, this statement array_keys($array['a'] ?? []) is shorter.
I vote for the lengthy one: it has clearer intent and works slightly better if the key is not set. Having said that, I am fine either one.
This comment has been minimized.
This comment has been minimized.
Description (*)
A ban person in OM community asked me to create this PR. I reviewed it and to me. this is a valid PR.
Related Pull Requests
PR #4036