Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for discussion: Feature/add elements to stationary object classification type #661

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FlorianMueller87
Copy link
Contributor

@FlorianMueller87 FlorianMueller87 commented Aug 9, 2022

Reference to a related issue in the repository

#641

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_objects – StationaryObject – Classification - Type to be compatible with AUTOSAR ADI GeneralLandmarkClassificationType.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.2.105 General landmark classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_StationaryObject_Classification_Type branch 2 times, most recently from d31a300 to 397ad4c Compare August 12, 2022 07:15
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>
@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_StationaryObject_Classification_Type branch from 397ad4c to f222f40 Compare August 12, 2022 07:20
Stefan Cyliax and others added 3 commits August 12, 2022 09:21
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>
New elements: BARREL, GUIDE_POST, TUNNEL

Issue: OpenSimulationInterface#641
Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
Issue: OpenSimulationInterface#641
Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_StationaryObject_Classification_Type branch from f222f40 to 4be3d75 Compare August 12, 2022 07:21
@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Oct 17, 2022
@jdsika jdsika added this to the V3.6.0 milestone Oct 17, 2022
@jdsika
Copy link
Contributor

jdsika commented Oct 17, 2022

Comments:

  • Tunnel: This is part of Lane Boundary:Type:Structure. Why would we have tunnels without lanes going through them? Is it meant as an overhead structure? Please provide the documentation on how ADI did define tunnels in general and how differentiate between bridge, overhead structrue or rectengular structure?
  • Barrel: This could already be a TYPE_DELINEATOR or TYPE_BARRIER - why is further definition needed? What is exacly the definition of the BARREL?
  • Guide Post: This is a TYPE_REFLECTIVE_STRUCTURE?
  • It is a unique type

TODO:

  • SHARPEN definitions and ADD images
  • Potentially we have overdefined types here

@ClemensLinnhoff ClemensLinnhoff added the AUTOSAR ADI Topics connected to AUTOSAR ADI definition. label Mar 3, 2023
@jdsika jdsika modified the milestones: V3.6.0, V4.0.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AUTOSAR ADI Topics connected to AUTOSAR ADI definition. Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO23150 compliance: Adding new states to [StationaryObject – Classification - Type]
3 participants