Fix a SUMIF warning with some versions of PHP when having different l…

…ength of arrays provided as input

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com)
 and this project adheres to [Semantic Versioning](https://semver.org).
 
+## Pending
+
+* Fix a SUMIF warning with some versions of PHP when having different length of arrays provided as input
+
 ## [1.6.0] - 2019-01-02
 
 ### Added

src/PhpSpreadsheet/Calculation/MathTrig.php

@@ -1224,8 +1224,9 @@ public static function SUMIF($aArgs, $condition, $sumArgs = [])
             }
 
             $testCondition = '=' . $arg . $condition;
+            $sumValue = array_key_exists($key, $sumArgs) ? $sumArgs[$key] : 0;
 
-            if (is_numeric($sumArgs[$key]) &&
+            if (is_numeric($sumValue) &&
                 Calculation::getInstance()->_calculateFormulaValue($testCondition)) {
                 // Is it a value within our criteria and only numeric can be added to the result
                 $returnValue += $sumArgs[$key];

tests/data/Calculation/MathTrig/SUMIF.php

@@ -94,4 +94,30 @@
             [1],
         ],
     ],
+    [
+        3,
+        [
+            [1],
+            [0],
+            [1]
+        ],
+        1,
+        [
+            [3],
+            [4] // less elements in sum array
+        ]
+    ],
+    [
+        3,
+        [
+            [1],
+            [0] // less elements in condition array
+        ],
+        1,
+        [
+            [3],
+            [4],
+            [5]
+        ]
+    ]
 ];