Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SUMIF when having different length of arrays provided as input #873

Closed
wants to merge 3 commits into from
Closed

Fix SUMIF when having different length of arrays provided as input #873

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2aaa296
Fix a SUMIF warning with some versions of PHP when having different l…
frantzmiccoli Feb 1, 2019
b8146e9
Trying to fix CI
frantzmiccoli Feb 4, 2019
298713c
--amend
frantzmiccoli Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Trying to fix CI
  • Loading branch information
@frantzmiccoli
frantzmiccoli committed Feb 4, 2019
commit b8146e92b63323c104ec2440aef8638972aca5fd
2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Calculation/MathTrig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ public static function SUMIF($aArgs, $condition, $sumArgs = [])
if (is_numeric($sumValue) &&
Calculation::getInstance()->_calculateFormulaValue($testCondition)) {
// Is it a value within our criteria and only numeric can be added to the result
$returnValue += $sumArgs[$key];
$returnValue += $sumValue;
}
}

Expand Down