Skip to content

Commit

Permalink
build:installNpmDeps is now silent
Browse files Browse the repository at this point in the history
Without this fix, the build fails with "stderr maxBuffer exceeded". Probably because new npm version is more verbose and outputs more information, the child process buffer is filled earlier. I started seeing the build fail after I merged elastic#6433 (I am following the 4.4 branch but I believe this applies everywhere).

A workaround is to increase the buffer size, or disable the output altogether. I chose silent mode because all output from this command is ignored anyway.

I am not sure if/why the official build works, though.
  • Loading branch information
PavelVanecek committed Mar 9, 2016
1 parent 9378729 commit 2f2e579
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tasks/build/installNpmDeps.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = function (grunt) {
grunt.registerTask('_build:installNpmDeps', function () {
grunt.file.mkdir('build/kibana/node_modules');

exec('npm install --production --no-optional', {
exec('npm install --production --no-optional --silent', {
cwd: grunt.config.process('<%= root %>/build/kibana')
}, this.async());
});
Expand Down

0 comments on commit 2f2e579

Please sign in to comment.