[4.4] Bump node to 4.3.2 #6433
Merged
[4.4] Bump node to 4.3.2 #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not going to merge this until we get consensus on it. |
PavelVanecek
added a commit
to PavelVanecek/kibana
that referenced
this pull request
Mar 9, 2016
Without this fix, the build fails with "stderr maxBuffer exceeded". Probably because new npm version is more verbose and outputs more information, the child process buffer is filled earlier. I started seeing the build fail after I merged elastic#6433 (I am following the 4.4 branch but I believe this applies everywhere). A workaround is to increase the buffer size, or disable the output altogether. I chose silent mode because all output from this command is ignored anyway. I am not sure if/why the official build works, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major version upgrade of node for the 4.4 line, but it's necessary to fix a memory leak in our ssl implementation.
This release of node upgrades the openssl version to address some security fixes.
See https://nodejs.org/en/blog/release/v4.3.2/
For #6153
Backports #6420