Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part H of transition to support modernize-use-default-member-init #5899

Merged
merged 14 commits into from
Dec 21, 2023
Merged

Part H of transition to support modernize-use-default-member-init #5899

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c7a9e37
Part H of transition to support modernize-use-default-member-init
gnawme Dec 11, 2023
7a3aedd
Updated per inspection
gnawme Dec 12, 2023
370b9bd
Corrected formatting complaints
gnawme Dec 12, 2023
c9c6686
Addressed CI clang-tidy issues
gnawme Dec 12, 2023
1cd4a9c
Fixed another CI clang-tidy complaint
gnawme Dec 13, 2023
912cbae
Fixed yet more CI clang-tidy issues
gnawme Dec 13, 2023
f3a5192
Made changes per review
gnawme Dec 15, 2023
72ba0f3
Fixed some typos
gnawme Dec 15, 2023
1f58867
Addressed more review changes
gnawme Dec 18, 2023
b52465d
Fixed new clang-tidy CI complaints
gnawme Dec 19, 2023
145ac52
Fixed clang-format CI complaint
gnawme Dec 19, 2023
2c55e2d
Fixed another piecemeal clang-format complaint
gnawme Dec 19, 2023
7649cfe
Made more changes per review
gnawme Dec 20, 2023
3d0006d
Fixed missed review comment
gnawme Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed yet more CI clang-tidy issues
  • Loading branch information
@gnawme
gnawme committed Dec 15, 2023
commit 912cbaec7a08625229b858a1de57b72dcf067d16
6 changes: 3 additions & 3 deletions io/include/pcl/io/openni2_grabber.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,9 @@ namespace pcl
// Mapping from config (enum) modes to native OpenNI modes
std::map<int, pcl::io::openni2::OpenNI2VideoMode> config2oni_map_;

pcl::io::openni2::OpenNI2Device::CallbackHandle depth_callback_handle_;
pcl::io::openni2::OpenNI2Device::CallbackHandle image_callback_handle_;
pcl::io::openni2::OpenNI2Device::CallbackHandle ir_callback_handle_;
pcl::io::openni2::OpenNI2Device::CallbackHandle depth_callback_handle_{};
pcl::io::openni2::OpenNI2Device::CallbackHandle image_callback_handle_{};
pcl::io::openni2::OpenNI2Device::CallbackHandle ir_callback_handle_{};
bool running_{false};

CameraParameters rgb_parameters_{std::numeric_limits<double>::quiet_NaN ()};
Expand Down
4 changes: 0 additions & 4 deletions io/src/openni2_grabber.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ namespace

//////////////////////////////////////////////////////////////////////////////////////////////////////////////////
pcl::io::OpenNI2Grabber::OpenNI2Grabber (const std::string& device_id, const Mode& depth_mode, const Mode& image_mode)
: image_signal_ (), depth_image_signal_ (), ir_image_signal_ (), image_depth_image_signal_ ()
, ir_depth_image_signal_ (), point_cloud_signal_ (), point_cloud_i_signal_ ()
, point_cloud_rgb_signal_ (), point_cloud_rgba_signal_ ()
, depth_callback_handle_ (), image_callback_handle_ (), ir_callback_handle_ ()
{
// initialize driver
updateModeMaps (); // registering mapping from PCL enum modes to openni::VideoMode and vice versa
Expand Down