New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part H of transition to support modernize-use-default-member-init #5899

Merged

mvieth merged 14 commits into PointCloudLibrary:master from gnawme:feature/use-default-member-init-h

Dec 21, 2023

Contributor

gnawme commented Dec 12, 2023

Part H of #5665, the transition to add these checks to clang-tidy:

larshg reviewed

View reviewed changes

surface/include/pcl/surface/gp3.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

surface/include/pcl/surface/convex_hull.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

surface/include/pcl/surface/gp3.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

surface/include/pcl/surface/texture_mapping.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

surface/include/pcl/surface/texture_mapping.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

tracking/include/pcl/tracking/kld_adaptive_particle_filter.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

tracking/include/pcl/tracking/nearest_pair_point_cloud_coherence.h Outdated Show resolved Hide resolved

gnawme added 7 commits

December 15, 2023 10:57


          Part H of transition to support modernize-use-default-member-init

c7a9e37


          Updated per inspection

7a3aedd


          Corrected formatting complaints

370b9bd


          Addressed CI clang-tidy issues

c9c6686


          Fixed another CI clang-tidy complaint

1cd4a9c


          Fixed yet more CI clang-tidy issues

912cbae


          Made changes per review

f3a5192

gnawme force-pushed the feature/use-default-member-init-h branch from 6129edf to f3a5192 Compare

December 15, 2023 18:58


          Fixed some typos

72ba0f3

larshg reviewed

View reviewed changes

tracking/include/pcl/tracking/particle_filter.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

visualization/include/pcl/visualization/interactor_style.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

surface/include/pcl/surface/organized_fast_mesh.h Outdated Show resolved Hide resolved

gnawme added 4 commits

December 18, 2023 15:19


          Addressed more review changes

1f58867


          Fixed new clang-tidy CI complaints

b52465d


          Fixed clang-format CI complaint

145ac52


          Fixed another piecemeal clang-format complaint

2c55e2d

larshg previously approved these changes

View reviewed changes

mvieth reviewed

View reviewed changes

io/include/pcl/io/real_sense_2_grabber.h Outdated Show resolved Hide resolved

octree/include/pcl/octree/octree_pointcloud.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/grabcut_segmentation.h Outdated Show resolved Hide resolved

surface/include/pcl/surface/mls.h Outdated Show resolved Hide resolved

visualization/include/pcl/visualization/mouse_event.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/grabcut_segmentation.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/grabcut_segmentation.h Outdated Show resolved Hide resolved


          Made more changes per review

7649cfe

gnawme dismissed larshg’s stale review via

7649cfe

December 20, 2023 19:02


          Fixed missed review comment

3d0006d

mvieth approved these changes

View reviewed changes

Member

mvieth left a comment

Thank you!

mvieth merged commit 4a389e1 into PointCloudLibrary:master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment