-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual flow retries #7152
Manual flow retries #7152
Conversation
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This design is consistent with what we discussed yesterday. It's somewhat more complex than the "soft" restart, but I appreciate the protection against potential failure modes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions for ya
Perhaps we can separate the changes required for a hard-restart from the changes required to expose the existing retry mechanism? If they're in two pull requests we can first review exposure of the retry/restart mechanism via an API route then , separately and without blocking the feature we need to deliver, we can have a more extended discussion about adding an option to that route to perform a hard restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still seems way overcomplicated to me, in particular the need to separately track "retries", "restarts" and "run counts" suggests that the core motivation of running the flow again is being dominated by some degree of edge cases.
- clientside flow behavior is all passing
Simplify restarts into retries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 I really like how clean this feels now, nice work @anticorrelator!
closes #7127
Implements the ability to manually retry flow runs in terminal states by proposing an
AwaitingRetry
scheduled stateThis PR also includes a refactor of flow retry logic
This should significantly reduce the overhead of retrying flows with many task runs
Checklist
<link to issue>
"fix
,feature
,enhancement