Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual flow retries #7152

Merged
merged 97 commits into from
Oct 24, 2022
Merged

Manual flow retries #7152

merged 97 commits into from
Oct 24, 2022

Commits on Oct 12, 2022

  1. Sketch out flow restart overview

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5ac9b3e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    44c5ef7 View commit details
    Browse the repository at this point in the history

  3. Spike out flow restart logic

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f72a03b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    ca5edda View commit details
    Browse the repository at this point in the history

  5. Clean up flow restart logic

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    4dc7be0 View commit details
    Browse the repository at this point in the history

  6. Add rules constraining flow restarts

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e7a8a79 View commit details
    Browse the repository at this point in the history

  7. Only update task runs if no restart indicator has been set

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    407649f View commit details
    Browse the repository at this point in the history

  8. Restarted flows must have deployments

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    a23990a View commit details
    Browse the repository at this point in the history

  9. Fix bugs in restart policy

    @anticorrelator
    anticorrelator committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    1f74305 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Start adding restart tests

    @anticorrelator
    anticorrelator committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    62c0a70 View commit details
    Browse the repository at this point in the history

  2. Improve flow restart test

    @anticorrelator
    anticorrelator committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    8834274 View commit details
    Browse the repository at this point in the history

  3. Spike out SoftRetry example

    @anticorrelator
    anticorrelator committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    966c342 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    c4f99cb View commit details
    Browse the repository at this point in the history

  5. Move "soft" retry policy to FlowRetryPolicy

    @anticorrelator
    anticorrelator committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    86ce10d View commit details
    Browse the repository at this point in the history

  6. Use correct rule name

    @anticorrelator
    anticorrelator committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    beba97a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    a540968 View commit details
    Browse the repository at this point in the history

  2. Use retry logic for restarts

    @anticorrelator
    anticorrelator committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    78c2ab6 View commit details
    Browse the repository at this point in the history

  3. Use AwaitingRetry state for consistency

    @anticorrelator
    anticorrelator committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6cab09a View commit details
    Browse the repository at this point in the history

  4. ⚫

    @anticorrelator
    anticorrelator committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    96c8841 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    2bb6d3a View commit details
    Browse the repository at this point in the history

  2. Start consolidating Restart logic

    @anticorrelator
    anticorrelator committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    dde4c90 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Remove separate FlowRestartPolicy

    @anticorrelator
    anticorrelator committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    ce7d832 View commit details
    Browse the repository at this point in the history

  2. Use unified retry/restart rules

    @anticorrelator
    anticorrelator committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    91a549f View commit details
    Browse the repository at this point in the history

  3. Move update task run model method

    @anticorrelator
    anticorrelator committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    9339993 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Finish sketching out retry/restart logic

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    3bb2fac View commit details
    Browse the repository at this point in the history

  2. ⚫

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e01bc10 View commit details
    Browse the repository at this point in the history

  3. Attempt to update subflow retry state machine

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    94ab790 View commit details
    Browse the repository at this point in the history

  4. ⚫

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    a335c7d View commit details
    Browse the repository at this point in the history

  5. Remove special handling for subflow tasks

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    6c57b90 View commit details
    Browse the repository at this point in the history

  6. Only rerun subflows that have not completed

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b852fde View commit details
    Browse the repository at this point in the history

  7. Permit restart transitions

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1409ac5 View commit details
    Browse the repository at this point in the history

  8. Update restart test

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    660ca4f View commit details
    Browse the repository at this point in the history

  9. Remove needless imports

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0deb7af View commit details
    Browse the repository at this point in the history

  10. Update flow retry tests

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    07d9f72 View commit details
    Browse the repository at this point in the history

  11. Spike out message passing between rules

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ba45c0b View commit details
    Browse the repository at this point in the history

  12. ⚫

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    7a18dd1 View commit details
    Browse the repository at this point in the history

  13. Remove needless import

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0d997c0 View commit details
    Browse the repository at this point in the history

  14. Pass more explicit messages between rules

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    da08672 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    834bfb7 View commit details
    Browse the repository at this point in the history

  16. Revert unintentional change to a rule

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    100b79e View commit details
    Browse the repository at this point in the history

  17. Add migrations

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ebf1136 View commit details
    Browse the repository at this point in the history

  18. Use updated columns

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ffb50f7 View commit details
    Browse the repository at this point in the history

  19. Remove unused model methods and schema actions

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    794b36d View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    f3db390 View commit details
    Browse the repository at this point in the history

  21. Add test for passing context parameters between rules

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    3b5c7df View commit details
    Browse the repository at this point in the history

  22. Update restart test

    @anticorrelator
    anticorrelator committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    38e9bf5 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Add tests for FlowRestart rule

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    b28208f View commit details
    Browse the repository at this point in the history

  2. Start adding tests for rerunning tasks on restart/retry

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    8bbc98f View commit details
    Browse the repository at this point in the history

  3. Refactor task rerunning rule for clarity

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    85d81b5 View commit details
    Browse the repository at this point in the history

  4. Fix assertion

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d1854b2 View commit details
    Browse the repository at this point in the history

  5. Fix test

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2a785c4 View commit details
    Browse the repository at this point in the history

  6. Add FizzlingRule fixture and cleanup test for rerunning rule

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a8dc688 View commit details
    Browse the repository at this point in the history

  7. ⚫

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    15c6e17 View commit details
    Browse the repository at this point in the history

  8. Permit rerunning tasks during the last flow retry

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c4e84b4 View commit details
    Browse the repository at this point in the history

  9. Remove needless imports

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    bad94df View commit details
    Browse the repository at this point in the history

  10. Test restarting flows via API

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    bb54b55 View commit details
    Browse the repository at this point in the history

  11. Change restart tests to use `set_statee instead of dedicated route

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c71fe93 View commit details
    Browse the repository at this point in the history

  12. Remove dedicated restart flow run route

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    43bef0c View commit details
    Browse the repository at this point in the history

  13. ⚫

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a289c93 View commit details
    Browse the repository at this point in the history

  14. Bump minor API version (?)

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    ca6ccf8 View commit details
    Browse the repository at this point in the history

  15. Create flow runs using model directly instead of modifying create schema

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    af8dffc View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a6b69ed View commit details
    Browse the repository at this point in the history

  17. Remove AwaitingRestart convenience constructor

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c37af3e View commit details
    Browse the repository at this point in the history

  18. Add docstrings

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    407507a View commit details
    Browse the repository at this point in the history

  19. Bump minimum API version

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9b347d3 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    59ca469 View commit details
    Browse the repository at this point in the history

  21. Fix issues with conflicting migrations

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0e6f1f4 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0277ca1 View commit details
    Browse the repository at this point in the history

  23. Use models instead of create actions

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d2869f2 View commit details
    Browse the repository at this point in the history

  24. Revert version changes

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    669698a View commit details
    Browse the repository at this point in the history

  25. Add integration test for flow retries with subflows

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3267e82 View commit details
    Browse the repository at this point in the history

  26. Use correct name in integration test

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4b279ec View commit details
    Browse the repository at this point in the history

  27. Use better names

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    cdb4970 View commit details
    Browse the repository at this point in the history

  28. Add flow retry compatibility code to rules

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    156a9b1 View commit details
    Browse the repository at this point in the history

  29. ⚫

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6f45831 View commit details
    Browse the repository at this point in the history

  30. Add error handling to orchestration fixture

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9deb857 View commit details
    Browse the repository at this point in the history

  31. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5128133 View commit details
    Browse the repository at this point in the history

  32. Fix compatibility code

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e91aebd View commit details
    Browse the repository at this point in the history

  33. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    bedc6d0 View commit details
    Browse the repository at this point in the history

  34. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c58f6b4 View commit details
    Browse the repository at this point in the history

  35. Resolve another migration conflict

    @anticorrelator
    anticorrelator committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a0cbac2 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Fix restart bookkeeping logic

    @anticorrelator
    anticorrelator committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    80ec6fc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    ba32275 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Sketch out simplifying restarts as retries

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    3c1c322 View commit details
    Browse the repository at this point in the history

  2. Unify "retry" transition rules with "terminal state" rules

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    66fa7f2 View commit details
    Browse the repository at this point in the history

  3. Fix name errors 

    - clientside flow behavior is all passing
    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    61c0cb9 View commit details
    Browse the repository at this point in the history

  4. Rework core policy tests to use updated terminal state protection rules

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    12196be View commit details
    Browse the repository at this point in the history

  5. Update restart tests to check manual retry behavior

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    0251db0 View commit details
    Browse the repository at this point in the history

  6. Update tests that permit rerunning retrying tasks

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bdfb180 View commit details
    Browse the repository at this point in the history

  7. Update API tests for manual retries

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    cafb170 View commit details
    Browse the repository at this point in the history

  8. Remove extra columns

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    d3c43ca View commit details
    Browse the repository at this point in the history

  9. Rename retry_attempt to flow_run_run_count

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    65714ce View commit details
    Browse the repository at this point in the history

  10. Separate flow run tracking into its own rule for clarity

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4d6bdfb View commit details
    Browse the repository at this point in the history

  11. Merge pull request #7308 from PrefectHQ/simplify-restarts-into-retries 

    Simplify restarts into retries
    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    ddaf599 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    0d60365 View commit details
    Browse the repository at this point in the history

  13. Rename rules for clarity

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    d2c5f97 View commit details
    Browse the repository at this point in the history

  14. isort

    @anticorrelator
    anticorrelator committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    83d98cc View commit details
    Browse the repository at this point in the history