Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internacionalizacion de procedimientos #907

Merged
merged 10 commits into from
Mar 25, 2022
Merged

Internacionalizacion de procedimientos #907

merged 10 commits into from
Mar 25, 2022

Conversation

dlopezalvas
Copy link
Contributor

@dlopezalvas dlopezalvas commented Mar 10, 2022 •
edited
Loading

Related: #897

Proceds-blockly: Program-AR/proceds-blockly#10

Queda:

  • Cambiar la versión de Proceds-blockly una vez que se publique

asanzo
asanzo requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@asanzo asanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Gran laburo! 👏 👍

Hay un par de cositas que marqué....

app/services/blocks-gallery.js Outdated Show resolved Hide resolved
app/services/blocks-gallery.js Outdated Show resolved Hide resolved
@asanzo
Copy link
Contributor

asanzo commented Mar 11, 2022 •
edited by dlopezalvas
Loading

Ah y no hay que olvidar

  • releasear y publicar proceds-blockly (una vez que esté) y acá poner la referencia correspondiente

Base automatically changed from wrapTranslationsWithNamespace to develop March 17, 2022 18:07
@dlopezalvas
Copy link
Contributor Author

También quedaron algunas cosillas (mensajes de errores) sin traducir dentro de blocks-gallery, como por ejemplo estos:

https://github.com/Program-AR/pilas-bloques/blob/92d463dc51f78beee30b6864a65f2ee8e7ca2ab5/app/services/blocks-gallery.js#L1356-L1357

No se si aprovechar a cambiarlo en este PR, son detallitos rapiditos creo.

asanzo
asanzo approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@asanzo asanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ¡Para mí está! (Salvo un error pavo de traducción).
👏 👏
@dlopezalvas si te parece cambialo a Ready for Review, y de paso ya releaseá proceds-blockly y cambiá el número acá. No importa si falta un review, cualquier cosa se vuelve a hacer. Pero es importante para empezar a ver que acá corran los tests y etcéteras.

app/index.html Show resolved Hide resolved
app/services/blocks-gallery.js Show resolved Hide resolved
tests/index.html Outdated Show resolved Hide resolved
translations/blocks/en-us.yaml Outdated Show resolved Hide resolved
translations/blocks/es-ar.yaml Outdated Show resolved Hide resolved
@dlopezalvas dlopezalvas marked this pull request as ready for review March 22, 2022 20:06
@dlopezalvas dlopezalvas requested a review from a team as a code owner March 22, 2022 20:06
@asanzo asanzo merged commit b9b7d18 into develop Mar 25, 2022
@asanzo asanzo deleted the procedures-internationalization branch March 25, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanzo asanzo asanzo approved these changes

@tfloxolodeiro tfloxolodeiro tfloxolodeiro approved these changes

@ezequielPereyra ezequielPereyra Awaiting requested review from ezequielPereyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlopezalvas @asanzo @tfloxolodeiro