Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internacionalizacion de procedimientos #10

Merged
merged 7 commits into from
Mar 25, 2022

Conversation

dlopezalvas
Copy link
Contributor

Copy link
Contributor

@asanzo asanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grosa!! Pero al leerlo me dí cuenta de un problema. Ahí aclaro, fijate si te cierra lo que propongo.

proceds-blockly.js Outdated Show resolved Hide resolved
Copy link
Contributor

@asanzo asanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo @dlopezalvas !!!! 👏 👏 .

Hice un comentario con algo para que pruebes si arregla el error. (el window)

README.md Show resolved Hide resolved
proceds-blockly.js Outdated Show resolved Hide resolved
@asanzo
Copy link
Contributor

asanzo commented Mar 22, 2022

@dlopezalvas está genial esto. Dado que estamos por deprecar una forma de usarlo (aunque todavía sigue funcionando) yo subiría una version minor (o sea pasar de 1.0.1 a 1.1.0, en lugar de 1.0.2).
Si alguna vez matamos el método initProcedsBlockly del todo, hay que subir la major y pasar a 2.0.0, pero por ahora no me parece necesario.

Que @tfloxolodeiro o @ezequielPereyra hagan el merge si no tienen comment ;)

(estoy intentando que al menos 2 de nosotres hagamos review por cada PR, al menos mientras estamos aprendiendo y conociendo los proyectos).

@asanzo asanzo merged commit ea18d66 into master Mar 25, 2022
@asanzo asanzo deleted the procedures-internationalization branch March 25, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants