Allow control plane static pods #120
Conversation
Signed-off-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Signed-off-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
|
@xanmanning I noticed you assigned me to the PR, is there anything you want me to do/change before you review it? 🙂 |
|
Sorry @bjw-s , I was meant to assign myself but I was doing it from my phone whilst waiting about between jobs so a bit absent minded. I've changed it to me and I'll review it after work tonight 😃 |
|
No problem! |
| @@ -39,6 +39,11 @@ | |||
| - k3s_primary_control_node | |||
| - k3s_server_manifests_templates | length > 0 | |||
|
|
|||
| - import_tasks: build/preconfigure-k3s-static-pod-manifests.yml | |||
| when: | |||
| - k3s_control_node | |||
There was a problem hiding this comment.
Does it make sense to make this k3s_primary_control_node ?
There was a problem hiding this comment.
It depends I guess? If you want to deploy Pods there (such as for kube-vip), I think the manifest should go on all of the control plane nodes.
There was a problem hiding this comment.
You are probably right, let's keep it this way. I know for the other manifest option it makes sense to put them on a single controller node. Static pods might behave differently.
There was a problem hiding this comment.
Static pods are directly tied to their kubelet (they're essentially a container outside of the cluster, represented by a mirror object inside the cluster) therefore they must be deployed individually to each control node.
Allow control plane static pods
Summary
This adds support for specifying static pod manifests through
k3s_server_pod_manifests_templates, similar to how automatic manifests are being pre-configured withk3s_server_manifests_templates.Fixes #118
Issue type
Test instructions
k3s_server_pod_manifests_templates, it should be deployed on all control plane nodes.