-
Notifications
You must be signed in to change notification settings - Fork 749
Missing default thumbnail for tutorials after nbsphinx 0.9 release #1707
Comments
See also Qiskit/qiskit_sphinx_theme#221 where I noted this along with the change to the tile sizes/spacing. |
Sorry I missed the issue you filed in the theme repo. Thanks for adding the additional details. I wonder whether we should just pin nbsphinx to <0.9. The 0.9 release doesn't add much new features that we will need. |
We would have to pin in quite a few repos now, I imagine, if that's the choice. I see here https://github.com/spatialaudio/nbsphinx/releases/tag/0.9.0 it says
Another way, given the above, might be to add the sphere image as part of the copyright widget that we add at the end of the notebooks. That widget is in Terra though and since the docs are built/published off stable that seems not so much a short term workaround/fix. I imagine either would cater to the thumbnail. I did not investigate the style change (size, spacing, colors - is now the standard link colors - purple in this case). |
spatialaudio/nbsphinx#723 (comment) The nbsphinx issue for default image was commented on - indeed it was changed, but seems there is a way. |
@Eric-Arellano FYI, this is not a theme issue. The fix should be in the |
It seemed we could also drop an .svg image in static, of the right name, which would be picked up on. If that was done I would think the static folder of the deployed docs could be updated on the server so that a fix could be done without republishing, as well of course as adding it to each project. If we kept the former .png file too then things would be more independent of the nbsphinx version. |
I don't know how to convert png to svg. I can possibly get an original svg from design team, but I go with the .png file approach because it's faster. You can see here: Qiskit/qiskit#1708. It's a simple fix.
|
### Summary This PR follows Qiskit/qiskit#9705 to remove the dependency on `sphinx-autodoc-typehints` and Qiskit/qiskit-metapackage#1707 to use the default Qiskit icon when the experiment manual isn't explicitly provided. ### Details and comments In addition, some experiment classes that didn't link to their manuals have been updated with the link. Manual line breaks added after numbered lists have been removed now that Qiskit/qiskit_sphinx_theme#218 has been merged.
Informations
What is the current behavior?
Steps to reproduce the problem
Go to https://qiskit.org/documentation/tutorials.html
What is the expected behavior?
The thumbnail default to qiskit logo when it's not set https://qiskit.org/documentation/stable/0.42/tutorials.html
Suggested solutions
The text was updated successfully, but these errors were encountered: