This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
Fix tutorials default thumbnail #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuangJunye
requested review from
mtreinish,
jakelishman,
kevinhartman,
javabster and
Eric-Arellano
as code owners
HuangJunye
commented
Mar 28, 2023
Comment on lines
-166
to
-82
| 'tutorials/optimization/1_quadratic_program': | ||
| '_static/optimization/1_quadratic_program.png', | ||
| 'tutorials/optimization/2_converters_for_quadratic_programs': | ||
| '_static/optimization/2_converters.png', | ||
| 'tutorials/optimization/3_minimum_eigen_optimizer': | ||
| '_static/optimization/3_min_eig_opt.png', | ||
| 'tutorials/optimization/4_grover_optimizer': | ||
| '_static/optimization/4_grover.png', | ||
| 'tutorials/optimization/5_admm_optimizer': | ||
| '_static/optimization/5_ADMM.png', |
There was a problem hiding this comment.
Optimization tutorials have been moved to qiskit-optimizations a long while ago.
This was referenced Mar 28, 2023
1ucian0
added
the
automerge
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
* set default qiskit logo image * remove optimization tutorials thumbnails --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nbsphinx 0.9 release changed the behaviour of the default thumbnail of jupyter notebook galleries. This PR revert its behaviour back to default as qiskit logo when no explicit thumbnail is set in the notebook.
Fixes Qiskit/qiskit#1707
Details and comments
Other changes are removing redundant optimization tutorials that have been moved to qiskit-optimization a long time ago.
Screenshots
After
Before