Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate qiskit/transpiler/graysynth.py #10819

Closed
ShellyGarion opened this issue Sep 12, 2023 · 8 comments · Fixed by #11426
Closed

Deprecate qiskit/transpiler/graysynth.py #10819

ShellyGarion opened this issue Sep 12, 2023 · 8 comments · Fixed by #11426
Assignees
@ShellyGarion
Labels
API affects user-facing API change good first issue Good for newcomers synthesis
Milestone
0.46.0

Comments

@ShellyGarion
Copy link
Member

What should we add?

Continue the work in #9795 and deprecate qiskit/transpiler/graysynth.py.
The code now exists in the synthesis library:

  • cnot_synth is replaced by synth_cnot_count_full_pmh
  • graysynth is replaced by synth_cnot_phase_aam

One should follow Qiskit deprecation policy guidelines.
@ShellyGarion ShellyGarion added good first issue Good for newcomers type: feature request New feature or request API affects user-facing API change synthesis and removed type: feature request New feature or request labels Sep 12, 2023
@AmirAflak
Copy link

would like to take this :)

@ShellyGarion
Copy link
Member Author

Thanks @AmirAflak - I assigned you to this issue.

@1ucian0 1ucian0 added this to the 0.45.0 milestone Sep 14, 2023
@jakelishman jakelishman modified the milestones: 0.45.0, 0.46.0 Oct 10, 2023
@ShellyGarion
Copy link
Member Author

@AmirAflak - is there any progress with this issue? Thanks!

@border-b
Copy link
Contributor

Hi @ShellyGarion, if this is still open I would like to work on this!

@ShellyGarion
Copy link
Member Author

@border-b - thanks, I assigned you to this issue

prakharb10 added a commit to prakharb10/qiskit-terra that referenced this issue Oct 22, 2023
@prakharb10
Deprecate qiskit/transpiler/graysynth.py
58a3e7b 
Fixes Qiskit#10819
@prakharb10 prakharb10 mentioned this issue Oct 22, 2023
Closed
@ShellyGarion
Copy link
Member Author

ShellyGarion commented Oct 22, 2023 •
edited
Loading

@AmirAflak and @border-b - I'm unassigning you from this issue, as it seems that #11079 already covers this.

@rishabhRsinghvi
Copy link

@ShellyGarion so is it solved, then please close it.

@ShellyGarion
Copy link
Member Author

@ShellyGarion so is it solved, then please close it.

This issue could be closed only after PR #11079 will be merged, and that PR still needs more work.

@ShellyGarion ShellyGarion mentioned this issue Dec 18, 2023
Merged
@ShellyGarion ShellyGarion self-assigned this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShellyGarion ShellyGarion

Labels
API affects user-facing API change good first issue Good for newcomers synthesis
Projects
Contributor Monitoring
Status: Done
Milestone
0.46.0
6 participants
@1ucian0 @jakelishman @border-b @ShellyGarion @rishabhRsinghvi @AmirAflak