-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate transpiler/synthesis
#11079
Migrate transpiler/synthesis
#11079
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6602305890
💛 - Coveralls |
Hi @prakharb10 - Thank you very much for your contribution! As for the docs, you can also see them in the build artifact here: Indeed, it's not enough to copy the |
Hi @prakharb10 - are you still working on this PR? |
Hi @ShellyGarion. I'm planning on completing this PR. I looked at the reference PR, but I had some questions. Posting here too |
Another comment about the docs. If you want them to show up you need to update the For example, please add this line: qiskit/qiskit/synthesis/__init__.py Line 46 in 2935f0d |
Hi @prakharb10 - any progress with this PR? |
Hi @prakharb10 - since there is no progress with this PR, and since we have a strict deadline for deprecations for Qiskit 1.0 release, I will have a close your PR and start another PR soon. |
Hi @ShellyGarion |
Thank you @prakharb10 for your work, it is very much appreceated. I opened a new PR #11426 and added you as a co-author. |
Summary
Closes #10819
Partially adresses #9667
Details and comments
I'm unable to build the docs locally so please let me know if any doc changes are required.
I have just copied the
aqc
directory and updated references. Is it okay that the code exists in two places right now or should the (soon-to-be) deprecated methods call the new methods internally?Will add reno once changes are approved