Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and prepare for 0.7.1 release #1886

Merged
merged 3 commits into from
Mar 4, 2019

Conversation

mtreinish
Copy link
Member

Summary

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

Details and comments

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.
taalexander pushed a commit to nkanazawa1989/qiskit that referenced this pull request Mar 4, 2019
* Issue Qiskit#1186: Add test file for circuit drawers

This commit adds a new file `test_circuit_drawer`. It is created to test
all the circuit drawers: `circuit_drawer` as well as the underlying
circuit drawers.

This very commit contains a test case to test only behavior of
`circuit_drawer`. In particular, it checks how `circuit_drawer` handles
different provided values of `output` parameter.

* Add line breaks to follow the codestyle

* Add test case for underlying circuit drawers

This commit adds a test case for underlying circuit drawers. At the
moment, it tests only how circuit drawers behave while drawing a small
circuit. However, further tests of behaviour on greater circuits will be
added.

The test case works as follows: there are presaved references of how
each circuit drawer shall draw a particular small circuit which is
obtained upon calling of `_small_circuit` funtion. The test case makes
all circuit drawer to produce their versions of the small circuit and then
compares these versions with the corresponding references.

Since latex and matplotlib drawers produce pictures, the test case
compares the produced images while for text and latex source drawers it
compares bytes of the files.

* Add referencesfor medium circuit

* Remove redundant  variable

* Issue Qiskit#1886: Improve tests of circuit drawers

This commit completes the test case for different circuit drawers.
In particular, it adds tests and references for all circuit types. Also
it adds comments and structurizes the code.

* Force to skip testing of deprecated circuit_drawer fallback

* According to Qiskit#1628, import of QiskitTestCase was changed from relative
to absolute one

* Docstrings of functions were refactored in accordance with the project
codestyle. In particular, format of return string was changed.

* This commit changes defining the path to references locally in the test
file in favor of defining it qiskit-wide and the using
_get_resource_path of QiskitTestCase

* This commit moves common part of tests into a single function. Thus, it
significantly reduces code repetition.

* Update medium and large references for mpl

* As `assert_called_once` is available only for Python 3.6, the
corresponding usages of mock asserts were updated so that they can be
supported with Python 3.5. In particular, the were replaced to
`assert_called_once_with`.

* Fix style bug

* Add readable assert fail messages

* As different Python version (at least second digit matters,
probably versions of packages matters too, it is unknown up to now),
this commit adds mechanism to handle current Python version and to look
for references in the corresponding folder.

* Fix style bugs

* There were still some `assert_called_once` left after previous commits,
so I have now replaced them with `assert_called_once_with` and added a
dict of correspinding calling arguments

* Fix style bug

* Up to this moment all registers had their names generated automatically.
Hence, after consequent runs of several tests, their names could have
changed randomly. There was a function `_reset_indices` to cope with
this, but it didn't take into account any intermediate runs of other
tests. Now, each register is assigned with a constant name and thus no
fails should happen

* This commit changes the name to be set for all created registers and
changes the references correspondingly. In addition, it fixes a small
style bug.

* It seems that Travis has no pdflatex installed and thus, testing of
LaTeX drawer will obviously fail. So, this commit add handling of an
OSError.

* Add references for Python 3.7

* During previous commits it was discovered that `text_drawer` produces
different outputs for different versions of Python while drawing the
`deep_circuit`. In particular, outputs for Python 3.5, and 3.6 with 3.7
differ. A notorious fact is that they are not different in sense of some
minor things like spacing, they differs like there is a bug. So, until
this issue is managed, there should be no `deep_circuit` testing. Consequently, since all other cases produce similar outputs, they can be evaluated similarly without paying attention to the dependence on version.

* Thanks to @diego-plan9, this commits just replaces manual creation of
temporary directory with standard Python function.

* Update references for TestVisualizationImplementation

* Thanks to @diego-plan9, this commit moves functions common for
TestDrawingMethods and TestVisualizationImplementation to a common base
class, DrawingTestCase. Consequently, these test cases are inherited
from this class and still possess their previous functinalty.

* Fix style bug

* Fix style bugs

* Fix style bugs

* Fix style bug

* Following the @1ucian0 comment, this commit removes test for deprecated
fallback

* Fix style errors

* This commit at first, of course, update references to keep them in touch
with the underlying repository updates. But, as well, it removes
dependency on version of Python from the commented part of a setUp
function

* This commit follows the principle Qiskit#1571 and introduces an automatic
regeneration of references as soon as test file is called as a
standalone script. It is done as follows: as soon as this script is a
main one, it calls a static method of TestDrawingMethods class, which
regenerates the references, just before calling of the unittest
facilities.

In addition, this commit moves decalaration of all variables to the body
of class, not to the setUp methods, which turned out to be redundant.
Finally, it introduces a `setUpClass` for a TestDrawingMethods class to
create a ONE temporary folder for ALL the tests, not for each one
separately.

* Fix style bug
setup.py Show resolved Hide resolved
@atilag atilag merged commit d5791fa into Qiskit:stable Mar 4, 2019
@mtreinish mtreinish deleted the bump-version-and-prepare-release branch March 4, 2019 19:31
ajavadia pushed a commit that referenced this pull request Mar 10, 2019
* fix BasicAer sampling bug (#1624) (#1859)

* fix BasicAer sampling bug (#1624)

* fix BasicAer sampling bug

* changelog

* remove legacysimulator from test_compile

Conflicts:
    CHANGELOG.rst
    test/python/tools/test_compiler.py

The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.

(cherry picked from commit 5f7b2e7)

* Try pinning isort version

* Use constraints from last working version of lint

* Add requirements constraints too

* Bump version and prepare for 0.7.1 release (#1886)

* Bump version and prepare for 0.7.1 release

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters

* Updated changelog

* Fixed typo

* Reverted changes from merge with Stable

* Fixed changelog
ajavadia pushed a commit that referenced this pull request May 9, 2019
* fix BasicAer sampling bug (#1624) (#1859)

* fix BasicAer sampling bug (#1624)

* fix BasicAer sampling bug

* changelog

* remove legacysimulator from test_compile

Conflicts:
    CHANGELOG.rst
    test/python/tools/test_compiler.py

The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.

(cherry picked from commit 5f7b2e7)

* Try pinning isort version

* Use constraints from last working version of lint

* Add requirements constraints too

* Bump version and prepare for 0.7.1 release (#1886)

* Bump version and prepare for 0.7.1 release

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix instruction inheritance issues (#1900)

* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters

* Updated changelog

* Fixed typo

* Revert "Fix instruction inheritance issues (#1900)" (#1906)

This reverts commit 36d5d5d.

* Relax schema validation on backendconfiguration (#2258)

* Relax schema validation on backendconfiguration

The schema validation for backendconfig was set too tightly and it was
rejecting valid responses from the backend API. This potentially causes
issues when running against the api. This commit addresses this by
changing the schema validation to ensure that we properly validate the
response received by the backends and no longer reject valid responses
moving forward.

* Add changelog

* Fix tests and lint

* Bump version and prepare for 0.7.2 release (#2269)

To prepare for the 0.7.2 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix typo in changelog (#2270)

This finishes a last minute typo in the changelog to link to the correct
version.

* Install twine in wheel build jobs (#2290)

The wheel build jobs failed to install twine so when the jobs completed
and went to upload the wheels this failed because the command wasn't
found. This commit fixes the issue by installing twine as part of the
wheel build job set ups so that we can actually upload our built
binaries.

* fix

* check at the end

* undo order flip

* syntax

* DeprecationWarning message (#2350)

* clean up stable
ajavadia pushed a commit that referenced this pull request May 9, 2019
* fix BasicAer sampling bug (#1624) (#1859)

* fix BasicAer sampling bug (#1624)

* fix BasicAer sampling bug

* changelog

* remove legacysimulator from test_compile

Conflicts:
    CHANGELOG.rst
    test/python/tools/test_compiler.py

The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.

(cherry picked from commit 5f7b2e7)

* Try pinning isort version

* Use constraints from last working version of lint

* Add requirements constraints too

* Bump version and prepare for 0.7.1 release (#1886)

* Bump version and prepare for 0.7.1 release

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix instruction inheritance issues (#1900)

* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters

* Updated changelog

* Fixed typo

* Revert "Fix instruction inheritance issues (#1900)" (#1906)

This reverts commit 36d5d5d.

* Relax schema validation on backendconfiguration (#2258)

* Relax schema validation on backendconfiguration

The schema validation for backendconfig was set too tightly and it was
rejecting valid responses from the backend API. This potentially causes
issues when running against the api. This commit addresses this by
changing the schema validation to ensure that we properly validate the
response received by the backends and no longer reject valid responses
moving forward.

* Add changelog

* Fix tests and lint

* Bump version and prepare for 0.7.2 release (#2269)

To prepare for the 0.7.2 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix typo in changelog (#2270)

This finishes a last minute typo in the changelog to link to the correct
version.

* Install twine in wheel build jobs (#2290)

The wheel build jobs failed to install twine so when the jobs completed
and went to upload the wheels this failed because the command wasn't
found. This commit fixes the issue by installing twine as part of the
wheel build job set ups so that we can actually upload our built
binaries.

* level 2 and 3 honors seed_transpiler

* clean

* clean up!
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* Issue Qiskit#1186: Add test file for circuit drawers

This commit adds a new file `test_circuit_drawer`. It is created to test
all the circuit drawers: `circuit_drawer` as well as the underlying
circuit drawers.

This very commit contains a test case to test only behavior of
`circuit_drawer`. In particular, it checks how `circuit_drawer` handles
different provided values of `output` parameter.

* Add line breaks to follow the codestyle

* Add test case for underlying circuit drawers

This commit adds a test case for underlying circuit drawers. At the
moment, it tests only how circuit drawers behave while drawing a small
circuit. However, further tests of behaviour on greater circuits will be
added.

The test case works as follows: there are presaved references of how
each circuit drawer shall draw a particular small circuit which is
obtained upon calling of `_small_circuit` funtion. The test case makes
all circuit drawer to produce their versions of the small circuit and then
compares these versions with the corresponding references.

Since latex and matplotlib drawers produce pictures, the test case
compares the produced images while for text and latex source drawers it
compares bytes of the files.

* Add referencesfor medium circuit

* Remove redundant  variable

* Issue Qiskit#1886: Improve tests of circuit drawers

This commit completes the test case for different circuit drawers.
In particular, it adds tests and references for all circuit types. Also
it adds comments and structurizes the code.

* Force to skip testing of deprecated circuit_drawer fallback

* According to Qiskit#1628, import of QiskitTestCase was changed from relative
to absolute one

* Docstrings of functions were refactored in accordance with the project
codestyle. In particular, format of return string was changed.

* This commit changes defining the path to references locally in the test
file in favor of defining it qiskit-wide and the using
_get_resource_path of QiskitTestCase

* This commit moves common part of tests into a single function. Thus, it
significantly reduces code repetition.

* Update medium and large references for mpl

* As `assert_called_once` is available only for Python 3.6, the
corresponding usages of mock asserts were updated so that they can be
supported with Python 3.5. In particular, the were replaced to
`assert_called_once_with`.

* Fix style bug

* Add readable assert fail messages

* As different Python version (at least second digit matters,
probably versions of packages matters too, it is unknown up to now),
this commit adds mechanism to handle current Python version and to look
for references in the corresponding folder.

* Fix style bugs

* There were still some `assert_called_once` left after previous commits,
so I have now replaced them with `assert_called_once_with` and added a
dict of correspinding calling arguments

* Fix style bug

* Up to this moment all registers had their names generated automatically.
Hence, after consequent runs of several tests, their names could have
changed randomly. There was a function `_reset_indices` to cope with
this, but it didn't take into account any intermediate runs of other
tests. Now, each register is assigned with a constant name and thus no
fails should happen

* This commit changes the name to be set for all created registers and
changes the references correspondingly. In addition, it fixes a small
style bug.

* It seems that Travis has no pdflatex installed and thus, testing of
LaTeX drawer will obviously fail. So, this commit add handling of an
OSError.

* Add references for Python 3.7

* During previous commits it was discovered that `text_drawer` produces
different outputs for different versions of Python while drawing the
`deep_circuit`. In particular, outputs for Python 3.5, and 3.6 with 3.7
differ. A notorious fact is that they are not different in sense of some
minor things like spacing, they differs like there is a bug. So, until
this issue is managed, there should be no `deep_circuit` testing. Consequently, since all other cases produce similar outputs, they can be evaluated similarly without paying attention to the dependence on version.

* Thanks to @diego-plan9, this commits just replaces manual creation of
temporary directory with standard Python function.

* Update references for TestVisualizationImplementation

* Thanks to @diego-plan9, this commit moves functions common for
TestDrawingMethods and TestVisualizationImplementation to a common base
class, DrawingTestCase. Consequently, these test cases are inherited
from this class and still possess their previous functinalty.

* Fix style bug

* Fix style bugs

* Fix style bugs

* Fix style bug

* Following the @1ucian0 comment, this commit removes test for deprecated
fallback

* Fix style errors

* This commit at first, of course, update references to keep them in touch
with the underlying repository updates. But, as well, it removes
dependency on version of Python from the commented part of a setUp
function

* This commit follows the principle Qiskit#1571 and introduces an automatic
regeneration of references as soon as test file is called as a
standalone script. It is done as follows: as soon as this script is a
main one, it calls a static method of TestDrawingMethods class, which
regenerates the references, just before calling of the unittest
facilities.

In addition, this commit moves decalaration of all variables to the body
of class, not to the setUp methods, which turned out to be redundant.
Finally, it introduces a `setUpClass` for a TestDrawingMethods class to
create a ONE temporary folder for ALL the tests, not for each one
separately.

* Fix style bug
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859)

* fix BasicAer sampling bug (Qiskit#1624)

* fix BasicAer sampling bug

* changelog

* remove legacysimulator from test_compile

Conflicts:
    CHANGELOG.rst
    test/python/tools/test_compiler.py

The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.

(cherry picked from commit 5f7b2e7)

* Try pinning isort version

* Use constraints from last working version of lint

* Add requirements constraints too

* Bump version and prepare for 0.7.1 release (Qiskit#1886)

* Bump version and prepare for 0.7.1 release

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters

* Updated changelog

* Fixed typo

* Reverted changes from merge with Stable

* Fixed changelog
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
…2357)

* fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859)

* fix BasicAer sampling bug (Qiskit#1624)

* fix BasicAer sampling bug

* changelog

* remove legacysimulator from test_compile

Conflicts:
    CHANGELOG.rst
    test/python/tools/test_compiler.py

The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.

(cherry picked from commit 5f7b2e7)

* Try pinning isort version

* Use constraints from last working version of lint

* Add requirements constraints too

* Bump version and prepare for 0.7.1 release (Qiskit#1886)

* Bump version and prepare for 0.7.1 release

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix instruction inheritance issues (Qiskit#1900)

* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters

* Updated changelog

* Fixed typo

* Revert "Fix instruction inheritance issues (Qiskit#1900)" (Qiskit#1906)

This reverts commit 36d5d5d.

* Relax schema validation on backendconfiguration (Qiskit#2258)

* Relax schema validation on backendconfiguration

The schema validation for backendconfig was set too tightly and it was
rejecting valid responses from the backend API. This potentially causes
issues when running against the api. This commit addresses this by
changing the schema validation to ensure that we properly validate the
response received by the backends and no longer reject valid responses
moving forward.

* Add changelog

* Fix tests and lint

* Bump version and prepare for 0.7.2 release (Qiskit#2269)

To prepare for the 0.7.2 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix typo in changelog (Qiskit#2270)

This finishes a last minute typo in the changelog to link to the correct
version.

* Install twine in wheel build jobs (Qiskit#2290)

The wheel build jobs failed to install twine so when the jobs completed
and went to upload the wheels this failed because the command wasn't
found. This commit fixes the issue by installing twine as part of the
wheel build job set ups so that we can actually upload our built
binaries.

* fix

* check at the end

* undo order flip

* syntax

* DeprecationWarning message (Qiskit#2350)

* clean up stable
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859)

* fix BasicAer sampling bug (Qiskit#1624)

* fix BasicAer sampling bug

* changelog

* remove legacysimulator from test_compile

Conflicts:
    CHANGELOG.rst
    test/python/tools/test_compiler.py

The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.

(cherry picked from commit 5f7b2e7)

* Try pinning isort version

* Use constraints from last working version of lint

* Add requirements constraints too

* Bump version and prepare for 0.7.1 release (Qiskit#1886)

* Bump version and prepare for 0.7.1 release

To prepare for the 0.7.1 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix instruction inheritance issues (Qiskit#1900)

* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters

* Updated changelog

* Fixed typo

* Revert "Fix instruction inheritance issues (Qiskit#1900)" (Qiskit#1906)

This reverts commit 36d5d5d.

* Relax schema validation on backendconfiguration (Qiskit#2258)

* Relax schema validation on backendconfiguration

The schema validation for backendconfig was set too tightly and it was
rejecting valid responses from the backend API. This potentially causes
issues when running against the api. This commit addresses this by
changing the schema validation to ensure that we properly validate the
response received by the backends and no longer reject valid responses
moving forward.

* Add changelog

* Fix tests and lint

* Bump version and prepare for 0.7.2 release (Qiskit#2269)

To prepare for the 0.7.2 bugfix release we need to increase the version
number and update the changelog. This commit takes care of that so we
can tag the release and build it.

* Fix typo in changelog (Qiskit#2270)

This finishes a last minute typo in the changelog to link to the correct
version.

* Install twine in wheel build jobs (Qiskit#2290)

The wheel build jobs failed to install twine so when the jobs completed
and went to upload the wheels this failed because the command wasn't
found. This commit fixes the issue by installing twine as part of the
wheel build job set ups so that we can actually upload our built
binaries.

* level 2 and 3 honors seed_transpiler

* clean

* clean up!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants