Transpiler add passes that might be out of the default basis #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix BasicAer sampling bug (Qiskit#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too
* Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it.
* Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo
This reverts commit 36d5d5d.
* Relax schema validation on backendconfiguration The schema validation for backendconfig was set too tightly and it was rejecting valid responses from the backend API. This potentially causes issues when running against the api. This commit addresses this by changing the schema validation to ensure that we properly validate the response received by the backends and no longer reject valid responses moving forward. * Add changelog * Fix tests and lint
To prepare for the 0.7.2 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it.
This finishes a last minute typo in the changelog to link to the correct version.
The wheel build jobs failed to install twine so when the jobs completed and went to upload the wheels this failed because the command wasn't found. This commit fixes the issue by installing twine as part of the wheel build job set ups so that we can actually upload our built binaries.
1ucian0
requested review from
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
mtreinish,
nonhermitian and
taalexander
as code owners
ajavadia
reviewed
May 8, 2019
ajavadia
reviewed
May 8, 2019
ajavadia
reviewed
May 8, 2019
ajavadia
previously approved these changes
May 8, 2019
ajavadia
approved these changes
May 9, 2019
ajavadia
added
the
stable backport potential
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
May 9, 2019
…2357) Fixes Qiskit#2349 When a basis is not defined for a circuit, the default basis set is the set of gates used in the circuit. This makes total sense to me. However, passes might add gates and the might be out of that bases. For this reason, I'm suggesting to add the base basis (UBase and CXBase) as part of the default basis set. If I understand correctly, the base basis (is that their name?) is supported by every backend by definition, so the gates that are added by the transpiler can run in the backend. (cherry picked from commit 4bfcc5d)
1ucian0
pushed a commit
that referenced
this pull request
May 10, 2019
…2386) Fixes #2349 When a basis is not defined for a circuit, the default basis set is the set of gates used in the circuit. This makes total sense to me. However, passes might add gates and the might be out of that bases. For this reason, I'm suggesting to add the base basis (UBase and CXBase) as part of the default basis set. If I understand correctly, the base basis (is that their name?) is supported by every backend by definition, so the gates that are added by the transpiler can run in the backend. (cherry picked from commit 4bfcc5d)
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
…2357) * fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859) * fix BasicAer sampling bug (Qiskit#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (Qiskit#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix instruction inheritance issues (Qiskit#1900) * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Revert "Fix instruction inheritance issues (Qiskit#1900)" (Qiskit#1906) This reverts commit 36d5d5d. * Relax schema validation on backendconfiguration (Qiskit#2258) * Relax schema validation on backendconfiguration The schema validation for backendconfig was set too tightly and it was rejecting valid responses from the backend API. This potentially causes issues when running against the api. This commit addresses this by changing the schema validation to ensure that we properly validate the response received by the backends and no longer reject valid responses moving forward. * Add changelog * Fix tests and lint * Bump version and prepare for 0.7.2 release (Qiskit#2269) To prepare for the 0.7.2 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix typo in changelog (Qiskit#2270) This finishes a last minute typo in the changelog to link to the correct version. * Install twine in wheel build jobs (Qiskit#2290) The wheel build jobs failed to install twine so when the jobs completed and went to upload the wheels this failed because the command wasn't found. This commit fixes the issue by installing twine as part of the wheel build job set ups so that we can actually upload our built binaries. * fix * check at the end * undo order flip * syntax * DeprecationWarning message (Qiskit#2350) * clean up stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2349
When a basis is not defined for a circuit, the default basis set is the set of gates used in the circuit. This makes total sense to me.
However, passes might add gates and the might be out of that bases. For this reason, I'm suggesting to add the base basis (
UBaseandCXBase) as part of the default basis set. If I understand correctly, the base basis (is that their name?) is supported by every backend by definition, so the gates that are added by the transpiler can run in the backend.