[Stable] Transpiler add passes that might be out of the default basis #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2357) Fixes Qiskit#2349 When a basis is not defined for a circuit, the default basis set is the set of gates used in the circuit. This makes total sense to me. However, passes might add gates and the might be out of that bases. For this reason, I'm suggesting to add the base basis (UBase and CXBase) as part of the default basis set. If I understand correctly, the base basis (is that their name?) is supported by every backend by definition, so the gates that are added by the transpiler can run in the backend. (cherry picked from commit 4bfcc5d)
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
nonhermitian and
taalexander
as code owners
ajavadia
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2349
When a basis is not defined for a circuit, the default basis set is the
set of gates used in the circuit. This makes total sense to me.
However, passes might add gates and the might be out of that bases. For
this reason, I'm suggesting to add the base basis (UBase and CXBase) as
part of the default basis set. If I understand correctly, the base
basis (is that their name?) is supported by every backend by
definition, so the gates that are added by the transpiler can run in
the backend.
(cherry picked from commit 4bfcc5d)
Details and comments
Backported from: #2357