Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 23Q4 scenario timestamp for desktop config #237

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

cjyetman
Copy link
Member

to keep in sync with #236

@cjyetman cjyetman requested a review from jdhoffa June 28, 2024 12:44
Copy link

Docker build status

commit_time git_sha image
2024-06-28T12:44:48Z 3467d4c ghcr.io/rmi-pacta/workflow.data.preparation:pr-237

@cjyetman cjyetman merged commit 168e9af into main Jun 28, 2024
7 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch June 28, 2024 13:01
jdhoffa added a commit that referenced this pull request Jul 1, 2024
The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data. 

The data was missing due to a bug that was introduced in:
RMI-PACTA/pacta.scenario.data.preparation#61

and later solved by:
RMI-PACTA/pacta.scenario.data.preparation#63

The new scenario preparation outputs, in the directory: 
`2023Q4_20240701_T105302Z`

which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z

contain all the expected output datasets.
jdhoffa added a commit that referenced this pull request Jul 1, 2024
The initial scenario preparation configuration bump that was committed
in #236 and #237 pointed to a scenario preparation output that was
missing crucial data.

The data was missing due to a bug that was introduced in:
RMI-PACTA/pacta.scenario.data.preparation#61

and later solved by:
RMI-PACTA/pacta.scenario.data.preparation#63

The new scenario preparation outputs, in the directory:
`2023Q4_20240701_T105302Z`

which can be found here:
https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z

contain all the expected output datasets.
jdhoffa added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jul 1, 2024
The newly created data directory now contains APS and STEPS scenarios for WEO 2023 for the aviation, cement and steel sectors. 

With these scenarios missing, the executive summary couldn't render correctly. 

Relates to:
RMI-PACTA/workflow.data.preparation/pull/238
RMI-PACTA/workflow.data.preparation/pull/237
RMI-PACTA/workflow.data.preparation/pull/236
RMI-PACTA/pacta.scenario.data.preparation/pull/61
RMI-PACTA/pacta.scenario.data.preparation/pull/63
jdhoffa added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jul 18, 2024
The newly created data directory now contains APS and STEPS scenarios
for WEO 2023 for the aviation, cement and steel sectors.

Importantly also, we had to update paths to the new (real) `peer` files,
as those had to be re-run with those same latest scenarios.

With these scenarios missing, the executive summary couldn't render
correctly.

Relates to:
RMI-PACTA/workflow.data.preparation/pull/238
RMI-PACTA/workflow.data.preparation/pull/237
RMI-PACTA/workflow.data.preparation/pull/236
RMI-PACTA/pacta.scenario.data.preparation/pull/61
RMI-PACTA/pacta.scenario.data.preparation/pull/63

---------

Co-authored-by: Alex Axthelm <aaxthelm@rmi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants