Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: update 2023Q4 scenario preparation config path #238

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jul 1, 2024

The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data.

The data was missing due to a bug that was introduced in: RMI-PACTA/pacta.scenario.data.preparation#61

and later solved by:
RMI-PACTA/pacta.scenario.data.preparation#63

The new scenario preparation outputs, in the directory: 2023Q4_20240701_T105302Z

which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z

contain all the expected output datasets.

The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data. 

The data was missing due to a bug that was introduced in:
RMI-PACTA/pacta.scenario.data.preparation#61

and later solved by:
RMI-PACTA/pacta.scenario.data.preparation#63

The new scenario preparation outputs, in the directory: 
`2023Q4_20240701_T105302Z`

which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z

contain all the expected output datasets.
@jdhoffa jdhoffa requested a review from cjyetman as a code owner July 1, 2024 11:05
Copy link

github-actions bot commented Jul 1, 2024

Docker build status

commit_time git_sha image
2024-07-01T11:05:06Z bcfb8ff ghcr.io/rmi-pacta/workflow.data.preparation:pr-238

@jdhoffa jdhoffa merged commit c716443 into main Jul 1, 2024
7 checks passed
@jdhoffa jdhoffa deleted the jdhoffa-patch-1 branch July 1, 2024 11:21
jdhoffa added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jul 1, 2024
The newly created data directory now contains APS and STEPS scenarios for WEO 2023 for the aviation, cement and steel sectors. 

With these scenarios missing, the executive summary couldn't render correctly. 

Relates to:
RMI-PACTA/workflow.data.preparation/pull/238
RMI-PACTA/workflow.data.preparation/pull/237
RMI-PACTA/workflow.data.preparation/pull/236
RMI-PACTA/pacta.scenario.data.preparation/pull/61
RMI-PACTA/pacta.scenario.data.preparation/pull/63
jdhoffa added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jul 18, 2024
The newly created data directory now contains APS and STEPS scenarios
for WEO 2023 for the aviation, cement and steel sectors.

Importantly also, we had to update paths to the new (real) `peer` files,
as those had to be re-run with those same latest scenarios.

With these scenarios missing, the executive summary couldn't render
correctly.

Relates to:
RMI-PACTA/workflow.data.preparation/pull/238
RMI-PACTA/workflow.data.preparation/pull/237
RMI-PACTA/workflow.data.preparation/pull/236
RMI-PACTA/pacta.scenario.data.preparation/pull/61
RMI-PACTA/pacta.scenario.data.preparation/pull/63

---------

Co-authored-by: Alex Axthelm <aaxthelm@rmi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants