Do not EXPORT executable targets #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding executables to the exported targets means that their existance is required for any dependent project to use the generated cmake module, even though the executables are not required at compile/link-time. This is normally fine when building from source, but runs into issues with distributions like RedHat or Debian, who split projects into multiple packages, such as g2o-cli, g2o-devel, g2o-plugins, etc. There isn't any reason to require the executables to be present when linking against g2o libraries, so just remove them from the generated cmake module by dropping them from the exported target list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding executables to the exported targets means that their existance is required for any dependent project to use the generated cmake module, even though the executables are not required at compile/link-time. This is normally fine when building from source, but runs into issues with distributions like RedHat or Debian, who split projects into multiple packages, such as g2o-cli, g2o-devel, g2o-plugins, etc.
There isn't any reason to require the executables to be present when linking against g2o libraries, so just remove them from the generated cmake module by dropping them from the exported target list.