Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not EXPORT executable targets #833

Commits on Aug 29, 2024

  1. Do not EXPORT executable targets

    Adding executables to the exported targets means that their
    existance is required for any dependent project to use the
    generated cmake module, even though the executables are not
    required at compile/link-time.  This is normally fine when
    building from source, but runs into issues with distributions
    like RedHat or Debian, who split projects into multiple
    packages, such as g2o-cli, g2o-devel, g2o-plugins, etc.
    
    There isn't any reason to require the executables to be present
    when linking against g2o libraries, so just remove them from
    the generated cmake module by dropping them from the exported
    target list.
    iillyyaa committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    092bbee View commit details
    Browse the repository at this point in the history