Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious focal kcov failure on //math:gray_code_test #14424

Closed
ggould-tri opened this issue Dec 8, 2020 · 0 comments · Fixed by #14425
Closed

Spurious focal kcov failure on //math:gray_code_test #14424

ggould-tri opened this issue Dec 8, 2020 · 0 comments · Fixed by #14425
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters configuration: linux type: bug

Comments

@ggould-tri
Copy link
Contributor

https://drake-jenkins.csail.mit.edu/view/Nightly%20Production/job/linux-focal-gcc-bazel-nightly-coverage/188/ shows a kcov failure in //math:gray_code_test:

[4:21:03 AM]  FAIL: //math:gray_code_test (see /media/ephemeral0/ubuntu/workspace/linux-focal-gcc-bazel-nightly-coverage/_bazel_ubuntu/ff87c4a977881c9d152b1196a0dcb676/execroot/drake/bazel-out/k8-dbg/testlogs/math/gray_code_test/test.log)
[4:21:03 AM]  INFO: From Testing //math:gray_code_test:
[4:21:03 AM]  ==================== Test output for //math:gray_code_test:
[4:21:03 AM]  kcov: warning: Other status: 0x85

Local bisection points the finger at #14413, which is obviously unrelated and innocuous. Combined with its similarity to https://drake-jenkins.csail.mit.edu/view/Production/job/linux-focal-gcc-bazel-nightly-coverage/153/ , it is likely that this is an instance of known kcov bug SimonKagstrom/kcov#339

Ways of addressing this include:

  • Turn off kcov on gray_code_test
  • External or vendor a more recent kcov in our focal builds
  • Reorganize tests to perturb the binary, in the manner of perception: Split unit test cases #14283 (which "solved" the previous instance of kcov#339)
@ggould-tri ggould-tri added type: bug configuration: linux component: build system Bazel, CMake, dependencies, memory checkers, linters labels Dec 8, 2020
ggould-tri added a commit to ggould-tri/drake that referenced this issue Dec 8, 2020
@ggould-tri
Separate out the unit test for the degenerate case
ef96847 
 * This is a trivial disturbance to the test to correct
   a spurious kcov error; see
   SimonKagstrom/kcov#339
 * Closes RobotLocomotion#14424
@ggould-tri ggould-tri mentioned this issue Dec 8, 2020
Merged
ggould-tri added a commit to ggould-tri/drake that referenced this issue Dec 8, 2020
@ggould-tri
Separate out the unit test for the degenerate case
527070b 
 * This is a trivial disturbance to the test to correct
   a spurious kcov error; see
   SimonKagstrom/kcov#339
 * Closes RobotLocomotion#14424
ggould-tri added a commit that referenced this issue Dec 8, 2020
@ggould-tri
Separate out the unit test for the degenerate case (#14425)
0be3ddd 
* Separate out the unit test for the degenerate case

 * This is a trivial disturbance to the test to correct
   a spurious kcov error; see
   SimonKagstrom/kcov#339
 * Closes #14424
@DamrongGuoy DamrongGuoy mentioned this issue Mar 25, 2021
Closed
avalenzu pushed a commit to avalenzu/drake that referenced this issue Aug 4, 2021
controllers: Reorder inverse dynamics test cases
10cc635 
This is to work around a bug in kcov. See RobotLocomotion#14424 for more info.
@avalenzu avalenzu mentioned this issue Aug 4, 2021
Merged
jwnimmer-tri pushed a commit that referenced this issue Aug 5, 2021
controllers: Reorder inverse dynamics test cases (#15567)
30bd1c3 
This is to work around a bug in kcov. See #14424 for more info.
@ggould-tri ggould-tri mentioned this issue Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters configuration: linux type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate out the unit test for the degenerate case ggould-tri/drake
1 participant
@ggould-tri