Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perturbs multibody_plant_scalar_conversion_test to fix kcov failure #14825

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Perturbs multibody_plant_scalar_conversion_test to fix kcov failure #14825

merged 1 commit into from
Mar 25, 2021

Conversation

joemasterjohn
Copy link
Contributor

@joemasterjohn joemasterjohn commented Mar 25, 2021 •
edited by sherm1
Loading

Fixes #14824.

Changes a few DRAKE_DEMANDS into equivalent EXPECT_EQ statements to perturb the binary.

The first 80 bytes of the binary are now:

00000000   7F 45 4C 46  02 01 01 00  00 00 00 00  00 00 00 00  .ELF............
00000010   03 00 3E 00  01 00 00 00  B0 1A 0D 00  00 00 00 00  ..>.............
00000020   40 00 00 00  00 00 00 00  08 96 68 1B  00 00 00 00  @.........h.....
00000030   00 00 00 00  40 00 38 00  09 00 40 00  28 00 27 00  ....@.8...@.(.'.
00000040   06 00 00 00  04 00 00 00  40 00 00 00  00 00 00 00  ........@.......
00000050   40 00 00 00  00 00 00 00  40 00 00 00  00 00 00 00  @.......@.......

Avoiding the issue described in SimonKagstrom/kcov#339.

This change is Reviewable

@joemasterjohn joemasterjohn added component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure component: multibody plant MultibodyPlant and supporting code configuration: linux priority: high unused team: dynamics labels Mar 25, 2021
@DamrongGuoy DamrongGuoy self-assigned this Mar 25, 2021
DamrongGuoy
DamrongGuoy reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@DamrongGuoy DamrongGuoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@DamrongGuoy for feature review.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @joemasterjohn)

joemasterjohn
joemasterjohn commented Mar 25, 2021
View reviewed changes
Copy link
Contributor Author

@joemasterjohn joemasterjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@ggould-tri for platform, please.

Reviewable status: LGTM missing from assignee ggould-tri(platform) (waiting on @ggould-tri)

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Mar 25, 2021 •
edited by sherm1
Loading

:lgtm: platform.

@jwnimmer-tri jwnimmer-tri merged commit 6dfca1e into RobotLocomotion:master Mar 25, 2021
@joemasterjohn joemasterjohn deleted the plant_scalar_conversion_kcov_fix branch March 25, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamrongGuoy DamrongGuoy DamrongGuoy left review comments

Assignees

@jwnimmer-tri jwnimmer-tri

@DamrongGuoy DamrongGuoy

Labels
component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure component: multibody plant MultibodyPlant and supporting code configuration: linux priority: high unused team: dynamics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a workaround of a rare kcov bug that showed up in CI Nightly (kcov: warning: Other status: 0x85).
4 participants
@joemasterjohn @jwnimmer-tri @DamrongGuoy @ggould-tri