Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception message for bad geometry in .obj file. #21929

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Improve exception message for bad geometry in .obj file. #21929

wants to merge 17 commits into from

Commits on Oct 14, 2024

  1. Improve error message for bad geometry in .obj file.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b132c29 View commit details
    Browse the repository at this point in the history

  2. Respond to reviewer comments.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    837caa8 View commit details
    Browse the repository at this point in the history

  3. Respond to reviewer comments.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    523efd7 View commit details
    Browse the repository at this point in the history

  4. Respond to review comments.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d529e06 View commit details
    Browse the repository at this point in the history

  5. Improve documentation.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8809fb9 View commit details
    Browse the repository at this point in the history

  6. Better documentation.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e51258d View commit details
    Browse the repository at this point in the history

  7. Add parser test.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1fc535e View commit details
    Browse the repository at this point in the history

  8. Reduce cut/paste and signficantly simplify bad_geomety_volume_negativ… 

    …e.obj.
    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2bf07bb View commit details
    Browse the repository at this point in the history

  9. Improve comment in streamlined file.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    64d3ea1 View commit details
    Browse the repository at this point in the history

  10. Respond to many (but not all) of the reviewer comments.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5c9b27e View commit details
    Browse the repository at this point in the history

  11. Small wording improvement.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    260e8bb View commit details
    Browse the repository at this point in the history

  12. Add parser test.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3ef3f6e View commit details
    Browse the repository at this point in the history

  13. Update file BUILD.bazel file.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    89883a7 View commit details
    Browse the repository at this point in the history

  14. Move parser test from inertia_visualizer_test.cc to parsing/test/pars… 

    …er_test.cc
    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f1de446 View commit details
    Browse the repository at this point in the history

  15. Respond to review comments.

    mitiguy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0471220 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Add comments to help communicate the defects in the simple mesh (with… 

    … ONE face) contained in the file bad_geometry_volume_negative.obj
    mitiguy committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0f8cab7 View commit details
    Browse the repository at this point in the history

  2. wip: avoid throwing exceptions in parser implementation

    @rpoyner-tri
    rpoyner-tri committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3e16b60 View commit details
    Browse the repository at this point in the history