Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TlsByteVecUX deserialization #1132

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Fix TlsByteVecUX deserialization #1132

merged 2 commits into from
Jul 3, 2023

Conversation

imor
Copy link
Contributor

@imor imor commented Jul 2, 2023

This PR fixes the bug found in #1109. It adds a DeserializeBytes::tls_deserialize test for each of the TlsByteVecUX types and fixes the bug.

imor added 2 commits July 2, 2023 13:42
@imor
add a few failing tests
0a33b68
@imor
Fix a bug in TlsByteVecUX deserialization
75b498a 
The DeserializeBytes impl of TlsByteVecUX did not skip the length prefix
bytes.
@imor imor mentioned this pull request Jul 2, 2023
Merged
@franziskuskiefer franziskuskiefer self-requested a review July 3, 2023 08:02
franziskuskiefer
franziskuskiefer approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@franziskuskiefer franziskuskiefer merged commit e0e12c8 into RustCrypto:master Jul 3, 2023
12 checks passed
@imor imor deleted the fix_tls_byte_vec_deserialization branch August 20, 2023 11:51
@imor imor mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imor @franziskuskiefer