[FIX] Migrate from libnpmconfig to @npmcli/config #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
requested changes
Jun 5, 2023
d3xter666
force-pushed
the
fix-remove-deprecated-packages
branch
from
8f2b636
to
8976c24
Compare
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
d3xter666
force-pushed
the
fix-remove-deprecated-packages
branch
from
8976c24
to
cde5a95
Compare
matz3
previously requested changes
Jun 23, 2023
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
|
Internal smoke test succeeded (run no. 1398) |
RandomByte
reviewed
Jun 27, 2023
RandomByte
previously approved these changes
Jun 27, 2023
Now already cached through #_getPacote. Also, the initialization of the variable was async, invalidating the cache when called concurrently.
flovogt
approved these changes
Jun 27, 2023
RandomByte
changed the title
matz3
reviewed
Sep 1, 2023
| if (!this._npmConfig) { | ||
| const {default: libnpmconfig} = await import("libnpmconfig"); | ||
| const opts = { | ||
| cache: this._cacheDir, |
There was a problem hiding this comment.
There's a regression in this PR which removes the usage of a separate cacache dir within our .ui5 data directory.
With this PR the default cache of npm is unsed instead of our separate cache directory. I'll push a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: SAP/ui5-tooling#786
JIRA: CPOUI5FOUNDATION-631