Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated transitive dependencies with v3 #786

Closed
LukasHeimann opened this issue Feb 17, 2023 · 2 comments · Fixed by SAP/ui5-project#618
Closed

Deprecated transitive dependencies with v3 #786

LukasHeimann opened this issue Feb 17, 2023 · 2 comments · Fixed by SAP/ui5-project#618
Labels
enhancement New feature or request

Comments

@LukasHeimann
Copy link

Hi everyone,

I upgraded to the tooling v3 and node 18, and looked in more detail at the build output. I realized that there were a couple of deprecations that were not there a few months ago. I found no other issue mentioning this, so I'm creating this one here:

Expected Behavior

No deprecated dependencies used within ui5-tooling.

Current Behavior

npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm WARN deprecated libnpmconfig@1.2.1: This module is not used anymore. npm config is parsed by npm itself and by @npmcli/config
npm WARN deprecated libnpmconfig@1.2.1: This module is not used anymore. npm config is parsed by npm itself and by @npmcli/config

Steps to Reproduce the Issue

In a new project (or just any empty folder), execute npm i @ui5/cli.

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 3.0.1
  • Node.js Version: 18.14.0
  • npm Version: 8.19.2
  • OS/Platform: windows

Log Output / Stack Trace

$ npm ls @npmcli/move-file
├─┬ @ui5/cli@3.0.1
│ └─┬ @ui5/project@3.0.1
│   └─┬ pacote@15.1.0
│     └─┬ @npmcli/run-script@6.0.0
│       └─┬ node-gyp@9.3.1
│         └─┬ make-fetch-happen@10.2.1
│           └─┬ cacache@16.1.3
│             └── @npmcli/move-file@2.0.1
└─┬ karma-ui5@3.0.1
  └─┬ @ui5/project@3.0.1
    └─┬ pacote@15.1.0
      └─┬ @npmcli/run-script@6.0.0
        └─┬ node-gyp@9.3.1
          └─┬ make-fetch-happen@10.2.1
            └─┬ cacache@16.1.3
              └── @npmcli/move-file@2.0.1

$ npm ls libnpmconfig
├─┬ @ui5/cli@3.0.1
│ └─┬ @ui5/project@3.0.1
│   └── libnpmconfig@1.2.1
└─┬ karma-ui5@3.0.1
  └─┬ @ui5/project@3.0.1
    └── libnpmconfig@1.2.1
@LukasHeimann LukasHeimann added bug Something isn't working needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Feb 17, 2023
@flovogt flovogt added enhancement New feature or request and removed bug Something isn't working needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Feb 17, 2023
@flovogt
Copy link
Member

flovogt commented Feb 17, 2023

Hi @LukasHeimann, thanks a lot for reporting this issue. We have this already in our backlog and will cover this in CPOUI5FOUNDATION-631. Currently, the deprecated modules still do their work so migrating to non deprecated ones will happen not in the near future. But of course, we will do it.

@flovogt
Copy link
Member

flovogt commented Mar 24, 2023

Just to point out.

RandomByte added a commit to SAP/ui5-project that referenced this issue Jun 27, 2023
Fixes: SAP/ui5-tooling#786
JIRA: CPOUI5FOUNDATION-631

---------

Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants