This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Update background color #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
I think because secondary is becoming white we should leave the other bg value as is for now. Thanks for fixing this @kyledurand ✨
|
@kyledurand you might want to align with @jessebc. He also made a PR for background color and secondary action color updates. #140 |
tmlayton
approved these changes
Aug 27, 2020
Merged
|
Closing in favor of #140 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background color has changed to
#f4f5f6in FigmaCloses: Shopify/polaris#3190
The lightness value was taken from putting the hex value into the tool at https://www.hsluv.org/
Sandbox
Question: Should we update the other
#111213values to use the new background color as well or is that too high risk of having other components change as well?