This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Update base.ts #140
Merged
Update base.ts #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to background contrast and secondary actions
|
Adding @kyledurand as he is working on the background and secondary actions. |
Closed
|
Hey Jesse, I also have a PR up that addresses the background color and matches figma 💯 % I have a sandbox where you can test my changes to the base config and role color here: https://codesandbox.io/s/blissful-chandrasekhar-2ngcu?file=/App.js If you are happy with the values in this PR I can close mine, or I can help you to merge the two together. |
kyledurand
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Was able to 🎩 this here: https://codesandbox.io/s/reverent-herschel-cmtkh?file=/App.js
I think we're good with these changes and I can close #139
alex-page
approved these changes
Aug 27, 2020
|
Just updated the changelog. I'm going to ship this on green and work on a release |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to background contrast and secondary actions
https://github.com/Shopify/polaris-ux/issues/424