activeClients debug message shows wrong information #199
Conversation
|
Why it calculates wrong? I think it should be substracted somewhere. |
|
Yes I agree but... |
|
@kireevco : This is not a feature but a bug-fix. |
|
@hreintke sorry,that's what I meant - hotfix/active-clients-debug We are trying to align with git-flow, it will be happening gradually |
| @@ -128,7 +128,7 @@ err_t TcpServer::onAccept(tcp_pcb *clientTcp, err_t err) | |||
| void TcpServer::onClient(TcpClient *client) | |||
| { | |||
| activeClients++; | |||
| debugf("TcpServer onClient %s, activeClients = %d\r\n ",client->getRemoteIp().toString().c_str(),activeClients); | |||
| debugf("TcpServer onClient %s\r\n ",client->getRemoteIp().toString().c_str()); | |||
There was a problem hiding this comment.
bit picky, but do you want to remove the blank space on the end of the message?
There was a problem hiding this comment.
Sharp.. Should I update the PR or submit a new one ?
PS will be offline from now. Further tomorrow
There was a problem hiding this comment.
if you want to change that the ideal thing to do would be squash the second commit and the first together, but it doesn't look like the original repository still exists so i'd probably just leave it
|
@raburton : |
Fix grammatical error on the 404 page.
Update debugf message in TcpServer