Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activeClients debug message shows wrong information #199

Closed
wants to merge 1 commit into from
Closed

activeClients debug message shows wrong information #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sming/SmingCore/Network/TcpServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ err_t TcpServer::onAccept(tcp_pcb *clientTcp, err_t err)
void TcpServer::onClient(TcpClient *client)
{
activeClients++;
debugf("TcpServer onClient %s, activeClients = %d\r\n ",client->getRemoteIp().toString().c_str(),activeClients);
debugf("TcpServer onClient %s\r\n ",client->getRemoteIp().toString().c_str());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit picky, but do you want to remove the blank space on the end of the message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharp.. Should I update the PR or submit a new one ?

PS will be offline from now. Further tomorrow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to change that the ideal thing to do would be squash the second commit and the first together, but it doesn't look like the original repository still exists so i'd probably just leave it

if (clientConnectDelegate)
{
clientConnectDelegate(client);
Expand All @@ -138,7 +138,7 @@ void TcpServer::onClient(TcpClient *client)
void TcpServer::onClientComplete(TcpClient& client, bool succesfull)
{
activeClients--;
debugf("TcpSever onComplete : %s activeClients = %d\r\n",client.getRemoteIp().toString().c_str(),activeClients );
debugf("TcpSever onComplete : %s \r\n",client.getRemoteIp().toString().c_str());
if (clientCompleteDelegate)
{
clientCompleteDelegate(client,succesfull);
Expand Down