Add a smoke test for `spine-logging #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
=========================================
Coverage 74.73% 74.73%
Complexity 1143 1143
=========================================
Files 180 180
Lines 4203 4203
Branches 335 335
=========================================
Hits 3141 3141
Misses 934 934
Partials 128 128 |
yevhenii-nadtochii
force-pushed
the
update-config
branch
from
f4a1cb8
to
4e5378e
Compare
|
@alexander-yevsyukov PTAL |
alexander-yevsyukov
requested changes
Aug 4, 2023
| * | ||
| * The abstract base is provided by `Spine.Logging.smokeTest` dependency. | ||
| */ | ||
| internal class LoggingSmokeTest : AbstractLoggingSmokeTest() |
There was a problem hiding this comment.
Look, this is too abstract (pun intended). We need to test that logging in this project does something useful for this library.
alexander-yevsyukov
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
LGTM. Let's discuss the abstract test matter when @armiol is back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a smoke test for
spine-loggingto make sure that the logging is working in concrete modules.basemodule is the first one where this test is added. Further, it will be added to more modules.Spinedependency object will also be updated inconfigwhen this PR is approved.