Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a smoke test for `spine-logging #800

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Add a smoke test for `spine-logging #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a8d38f
Extend `Spine` dependency object with `smokeTest`
yevhenii-nadtochii Aug 3, 2023
2c9251d
Implement `LoggingSmokeTest`
yevhenii-nadtochii Aug 3, 2023
4e5378e
Bump version --> `2.0.0-SNAPSHOT.186`
yevhenii-nadtochii Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ dependencies {
}

testImplementation(Spine.testlib)
testImplementation(Spine.Logging.smokeTest)
}

tasks {
Expand Down
3 changes: 2 additions & 1 deletion buildSrc/src/main/kotlin/io/spine/internal/dependency/Spine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ object Spine {
*
* @see <a href="https://github.com/SpineEventEngine/logging">spine-logging</a>
*/
const val logging = "2.0.0-SNAPSHOT.197"
const val logging = "2.0.0-SNAPSHOT.198"

/**
* The version of [Spine.testlib].
Expand Down Expand Up @@ -164,6 +164,7 @@ object Spine {
const val lib = "$group:spine-logging:$version"
const val backend = "$group:spine-logging-backend:$version"
const val context = "$group:spine-logging-context:$version"
const val smokeTest = "$group:spine-logging-smoke-test:$version"
}

/**
Expand Down
17 changes: 2 additions & 15 deletions license-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@


# Dependencies of `io.spine:spine-base:2.0.0-SNAPSHOT.185`
# Dependencies of `io.spine:spine-base:2.0.0-SNAPSHOT.186`

## Runtime
1. **Group** : com.google.code.findbugs. **Name** : jsr305. **Version** : 3.0.2.
Expand All @@ -17,14 +17,6 @@
1. **Group** : com.google.errorprone. **Name** : error_prone_type_annotations. **Version** : 2.18.0.
* **License:** [Apache 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : com.google.flogger. **Name** : flogger. **Version** : 0.7.4.
* **Project URL:** [https://github.com/google/flogger](https://github.com/google/flogger)
* **License:** [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : com.google.flogger. **Name** : flogger-system-backend. **Version** : 0.7.4.
* **Project URL:** [https://github.com/google/flogger](https://github.com/google/flogger)
* **License:** [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : com.google.guava. **Name** : failureaccess. **Version** : 1.0.1.
* **Project URL:** [https://github.com/google/guava/](https://github.com/google/guava/)
* **License:** [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)
Expand All @@ -49,11 +41,6 @@
1. **Group** : com.google.protobuf. **Name** : protobuf-kotlin. **Version** : 3.23.4.
* **License:** [BSD-3-Clause](https://opensource.org/licenses/BSD-3-Clause)

1. **Group** : org.checkerframework. **Name** : checker-compat-qual. **Version** : 2.5.3.
* **Project URL:** [https://checkerframework.org](https://checkerframework.org)
* **License:** [GNU General Public License, version 2 (GPL2), with the classpath exception](http://www.gnu.org/software/classpath/license.html)
* **License:** [The MIT License](http://opensource.org/licenses/MIT)

1. **Group** : org.checkerframework. **Name** : checker-qual. **Version** : 3.27.0.
* **Project URL:** [https://checkerframework.org](https://checkerframework.org)
* **License:** [The MIT License](http://opensource.org/licenses/MIT)
Expand Down Expand Up @@ -781,4 +768,4 @@

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Tue Jul 25 16:12:31 EEST 2023** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Thu Aug 03 18:06:53 EEST 2023** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
12 changes: 9 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ all modules and does not describe the project structure per-subproject.
-->
<groupId>io.spine</groupId>
<artifactId>base</artifactId>
<version>2.0.0-SNAPSHOT.185</version>
<version>2.0.0-SNAPSHOT.186</version>

<inceptionYear>2015</inceptionYear>

Expand Down Expand Up @@ -50,7 +50,7 @@ all modules and does not describe the project structure per-subproject.
<dependency>
<groupId>io.spine</groupId>
<artifactId>spine-logging</artifactId>
<version>2.0.0-SNAPSHOT.197</version>
<version>2.0.0-SNAPSHOT.198</version>
<scope>compile</scope>
</dependency>
<dependency>
Expand All @@ -68,7 +68,7 @@ all modules and does not describe the project structure per-subproject.
<dependency>
<groupId>io.spine</groupId>
<artifactId>spine-logging-backend</artifactId>
<version>2.0.0-SNAPSHOT.197</version>
<version>2.0.0-SNAPSHOT.198</version>
<scope>runtime</scope>
</dependency>
<dependency>
Expand All @@ -95,6 +95,12 @@ all modules and does not describe the project structure per-subproject.
<version>5.6.2</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.spine</groupId>
<artifactId>spine-logging-smoke-test</artifactId>
<version>2.0.0-SNAPSHOT.198</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.spine.tools</groupId>
<artifactId>spine-testlib</artifactId>
Expand Down
36 changes: 36 additions & 0 deletions src/test/kotlin/io/spine/LoggingSmokeTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* Copyright 2023, TeamDev. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Redistribution and use in source and/or binary forms, with or without
* modification, must retain the above copyright notice and the following
* disclaimer.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

package io.spine

import io.spine.logging.AbstractLoggingSmokeTest

/**
* Checks that `spine-logging` library works correctly within `base` module.
*
* The abstract base is provided by `Spine.Logging.smokeTest` dependency.
*/
internal class LoggingSmokeTest : AbstractLoggingSmokeTest()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look, this is too abstract (pun intended). We need to test that logging in this project does something useful for this library.

2 changes: 1 addition & 1 deletion version.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

val versionToPublish: String by extra("2.0.0-SNAPSHOT.185")
val versionToPublish: String by extra("2.0.0-SNAPSHOT.186")