-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spv merge to spv 7 #942
Closed
Closed
Spv merge to spv 7 #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is the change that should allow it to work correctly in aha-flow
…straints as before
There's something weird/wrong about this pull request, I'm suspending it until I can figure it out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull is 7th in a series that so far includes #934 , #935 , #937 , #938 , #939 , #941 , slowly merging gf/onyx and tsmc/amber versions back into one, for a single common master branch.
After the most recent pull #941 , the two branches had 101 files difference between them. This pull cuts that down to 90:
Below is a summary of the changes included in this pull, along with an explanation of why each change should have no adverse impact on existing spVspV functionality.
full_chip/constraints_amber/
for the older constraints and kept the existing directoryfull_chip/constraints/
for the (unchanged) onyx constraints as the default. This required two changes:1a) Created a new directory
mflowgen/full_chip/constraints_amber/
containing the files:
1b) Updated full_chip/construct.py to use the older constraints only when it detects that we are building with the amber process (tsmc16).