-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more entities #2087
Merged
Merged
Implement more entities #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tornac1234
commented
Oct 6, 2023
•
edited
Loading
edited
- Sync oxygen pipes
- Sync beacons
- Fix containers not spawning
- Sync LED lights (and other similar entities)
- Prevent placeable objects from falling
- Sync flares
- Override UniqueIdentifier's Id by NitroxEntity's Id
- Add a real implementation of delta time (e.g for energy generation calculations)
- Add a new Instantiate wrapper to include a NitroxEntity right before the components are enabled
This was
linked to
issues
Oct 8, 2023
Ready for review :) |
Jannify
requested changes
Nov 6, 2023
NitroxClient/GameLogic/Spawning/WorldEntities/PlacedWorldEntitySpawner.cs
Outdated
Show resolved
Hide resolved
7bf8ab1
to
246e866
Compare
246e866
to
2ae1342
Compare
Jannify
reviewed
Nov 9, 2023
…longer fall under the map. Fixed beacons and slightly improved Entity Simulation movement management
…on which will always give a real delta time (uncapped)
…ects before its components are enabled, override UniqueIdentifier's id by NitroxEntity's id, implement more sync spawners
2ae1342
to
7c3bac7
Compare
Jannify
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM CW
tornac1234
commented
Nov 19, 2023
Measurity
reviewed
Nov 29, 2023
NitroxClient/GameLogic/Spawning/Metadata/Extractor/FlareMetadataExtractor.cs
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/Metadata/EntityMetadata.cs
Show resolved
Hide resolved
3 tasks
Note for latter PR: fix fish positioning in waterparks |
Measurity
approved these changes
Dec 3, 2023
dartasen
approved these changes
Dec 3, 2023
tornac1234
added a commit
to tornac1234/Nitrox
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.