Sync name and colors for vehicles, rocket and cyclops #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tornac1234
commented
Oct 29, 2023
•
tornac1234
commented
- When an entity is updated, ensure its children are also updated
- Fix, improve and implement name and colors sync/persistence for vehicles, rocket and cyclops
- Refactoring of metadata (moved EntityMetadataProcessors to their own folder, now use an interface for base EntityMetadataProcessor and EntityMetadataExtractor, replace static metadata extracting/applying to a DI instance call)
tornac1234
force-pushed
the
fix-metadata-echoing
branch
from
9c4ef4b
to
d3e5735
Compare
Jannify
requested changes
Nov 22, 2023
NitroxClient/GameLogic/Spawning/Metadata/Processor/CyclopsMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/Metadata/Processor/ExosuitMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/Metadata/Processor/KeypadMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/Metadata/EntityMetadata.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/Metadata/VehicleMetadata.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/Metadata/Processor/SubNameInputMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/Metadata/Processor/SubNameInputMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/Metadata/ExosuitMetadata.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/Metadata/NamedColoredMetadata.cs
Outdated
Show resolved
Hide resolved
tornac1234
force-pushed
the
fix-metadata-echoing
branch
from
d3e5735
to
3c05122
Compare
Jannify
requested changes
Nov 27, 2023
NitroxModel/DataStructures/GameLogic/Entities/Metadata/NamedColoredMetadata.cs
Show resolved
Hide resolved
tornac1234
commented
Dec 2, 2023
NitroxModel/DataStructures/GameLogic/Entities/Metadata/EntityMetadata.cs
Outdated
Show resolved
Hide resolved
Measurity
approved these changes
Dec 17, 2023
tornac1234
force-pushed
the
fix-metadata-echoing
branch
from
3c05122
to
1011417
Compare
|
Force pushed required changes and master rebase |
tornac1234
force-pushed
the
fix-metadata-echoing
branch
from
1011417
to
e17aaec
Compare
dartasen
approved these changes
Dec 18, 2023
Jannify
approved these changes
Dec 18, 2023
Jannify
reviewed
Dec 18, 2023
| @@ -21,12 +21,14 @@ public class Items | |||
| { | |||
| private readonly IPacketSender packetSender; | |||
| private readonly Entities entities; | |||
| public GameObject PickingUpObject { get; private set; } | |||
| public static GameObject PickingUpObject { get; private set; } | |||
There was a problem hiding this comment.
Would ike to move this after or before all the private readonly fields
tornac1234
added a commit
to tornac1234/Nitrox
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.