Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(metrics): add metrics labels test #1971

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Dec 13, 2021

  • add tests making asserts on actual metrics labels (using https://github.com/SumoLogic/sumologic-kubernetes-tools/releases/tag/v2.7.0)
  • change strings.NamespaceFromT(t) to include a partial timestamp so that users can run tests one after another without needing to wait for namespace to terminate
  • add README change about TEST_ARGS in integration tests
  • extract metrics to a separate feature
  • introduce receivermock.NewClientWithK8sTunnel()
  • introduce k8s.TunnelForReceiverMock()

@github-actions github-actions bot added the documentation documentation label Dec 13, 2021
@pmalek-sumo pmalek-sumo force-pushed the metrics-integration-tests branch 12 times, most recently from 89841f7 to e550bf1 Compare December 13, 2021 22:53
@pmalek-sumo pmalek-sumo marked this pull request as ready for review December 13, 2021 23:04
@pmalek-sumo pmalek-sumo requested a review from a team as a code owner December 13, 2021 23:04
@pmalek-sumo pmalek-sumo force-pushed the metrics-integration-tests branch 6 times, most recently from 3a14c44 to 0f95a94 Compare December 14, 2021 10:03
@pmalek-sumo pmalek-sumo changed the title tests(metrics): add metrics labels test test(metrics): add metrics labels test Dec 14, 2021
@pmalek-sumo pmalek-sumo force-pushed the metrics-integration-tests branch 2 times, most recently from 4100fc1 to fa400c4 Compare December 15, 2021 17:07
@pmalek-sumo pmalek-sumo merged commit f1263ec into main Dec 16, 2021
@pmalek-sumo pmalek-sumo deleted the metrics-integration-tests branch December 16, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants