test(traces): add integration test for enabled traces #1977
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pmalek-sumo
force-pushed
the
it-add-tracing-test
branch
from
be4fb1c
to
94c6cd3
Compare
pmalek-sumo
changed the title
pmalek-sumo
force-pushed
the
it-add-tracing-test
branch
2 times, most recently
from
ee02a90
to
bb56dca
Compare
|
Great work! Really like the tests 🚀 |
pmalek-sumo
force-pushed
the
it-add-tracing-test
branch
2 times, most recently
from
477e333
to
3e979a9
Compare
| enabled: true | ||
|
|
||
| # Prevent snowball effect by filtering out receiver mock logs | ||
| fluent-bit: |
There was a problem hiding this comment.
Why do we set this (and others like Prometheus or Fluentd) for tracing tests?
There was a problem hiding this comment.
I think we should include sumologic.traces.enabled: true and the otelcol and otelagent sections only 🤔
There was a problem hiding this comment.
This is to prevent fluent-bit ingesting receiver-mock logs, which would then be printed out on stdout and be ingested by fluent-bit and so on.
We could either keep this filter or disable logs for this particular testcase.
I'm open to suggestions but I thought that we should check that everything seems to work fine when we change a different config option like traces.enabled.
There was a problem hiding this comment.
Why do we set this (and others like Prometheus or Fluentd) for tracing tests?
There are comments explaining why we need them :) TLDR, with default requests those pods wouldn't fit on the github runner's node
pmalek-sumo
force-pushed
the
it-add-tracing-test
branch
from
3e979a9
to
ae570ab
Compare
Related to recent problem fixed in: #1975
This PR adds a test with traces enabled to verify that traces work with the chart by actually installing it in a cluster.
Depends on #1971