-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs)!: simplify metadata configuration #2626
Conversation
9413cad
to
3ecc55c
Compare
Could you add to the changelog below note or something similar? "Removed explicit configuration for otelcol under |
I can start a section for log config changes in the migration doc, but it'd just be the start. |
3ecc55c
to
f2cdd9a
Compare
14fb64c
to
8d9202a
Compare
8d9202a
to
ae8d028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 🏆
ae8d028
to
037f630
Compare
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Description
Move the logs metadata configuration to a template. We don't do much more here, there are more changes expected later, pulling out some of the configuration to top-level properties. I did make the configuration for containers and systemd conditional, same for the pipelines for otel log collector and Fluent Bit.
I've added two different ways of customizing the configuration directly. The contents of metadata.metrics.config.merge will be merged into the templated configuration, while metadata.metrics.config.override will replace it in total.
Migration can be found here: SumoLogic/sumologic-kubernetes-tools#387.
Checklist