Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): 修复边界滚动异常问题 #1425

Closed
wants to merge 0 commits into from

Conversation

HelKyle
Copy link
Contributor

@HelKyle HelKyle commented Sep 3, 2022

fix: Tencent/tdesign-vue-next#1012

关联子仓库:Tencent/tdesign-common#802

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(TimePicker): 修复边界滚动问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

完成

@uyarn
Copy link
Collaborator

uyarn commented Sep 3, 2022

看起来还需要配合common的before after改动才可以修复 你看看能把common切到你的commit上 并先在解决方案里写下处理方式吗

@HelKyle HelKyle changed the title fix: 尝试修复 time-picker 边界滚动异常问题 WIP: 尝试修复 time-picker 边界滚动异常问题 Sep 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1425 (78e6817) into develop (8a9ef3a) will increase coverage by 1.86%.
The diff coverage is 48.29%.

@@             Coverage Diff             @@
##           develop    #1425      +/-   ##
===========================================
+ Coverage    61.00%   62.86%   +1.86%     
===========================================
  Files         1030     1030              
  Lines        17933    17904      -29     
  Branches      4121     4089      -32     
===========================================
+ Hits         10940    11256     +316     
+ Misses        6993     6648     -345     
Impacted Files Coverage Δ
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) ⬇️
src/collapse/_usage/index.jsx 0.00% <0.00%> (ø)
src/config-provider/_example/global.jsx 100.00% <ø> (ø)
src/date-picker/DateRangePickerPanel.tsx 10.29% <0.00%> (-0.08%) ⬇️
src/date-picker/_example/panel.jsx 33.33% <0.00%> (-16.67%) ⬇️
src/date-picker/base/Header.tsx 42.66% <0.00%> (-1.17%) ⬇️
src/dialog/RenderDialog.tsx 65.51% <0.00%> (+5.17%) ⬆️
src/form/Form.tsx 67.85% <0.00%> (ø)
src/message/_example/close-function.jsx 41.66% <ø> (ø)
src/popconfirm/_example/describe.jsx 100.00% <ø> (ø)
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HelKyle
Copy link
Contributor Author

HelKyle commented Sep 3, 2022

看起来还需要配合common的before after改动才可以修复 你看看能把common切到你的commit伤 并先在解决方案里写下处理方式吗

@uyarn
排查下来是因为滚动到顶部(底部也一样)的时候,由于 before/after 的高度 50% 太大,导致 scroll 容器需要再往反方向滚动 15px,用户行为的滚动和 JS 调用 scrollTo 冲突导致怪异的问题出现。

现在的方案是,通过调整 before after 的高度,让滚动到顶部(或底部)的时候是自然的,不需要再反方向调整。

临时将 common 的代码加到我的分支上了,可以用 preview 链接看看,没问题我再更新这个 pr。

@uyarn
Copy link
Collaborator

uyarn commented Sep 3, 2022

看起来还需要配合common的before after改动才可以修复 你看看能把common切到你的commit伤 并先在解决方案里写下处理方式吗

@uyarn 排查下来是因为滚动到顶部(底部也一样)的时候,由于 before/after 的高度 50% 太大,导致 scroll 容器需要再往反方向滚动 15px,用户行为的滚动和 JS 调用 scrollTo 冲突导致怪异的问题出现。

现在的方案是,通过调整 before after 的高度,让滚动到顶部(或底部)的时候是自然的,不需要再反方向调整。

临时将 common 的代码加到我的分支上了,可以用 preview 链接看看,没问题我再更新这个 pr。

看起来效果很ok 👍🏻 我去看看common的代码 没有问题合并之后你checkout下submodule回主干

@uyarn uyarn changed the title WIP: 尝试修复 time-picker 边界滚动异常问题 fix(timepicker): 修复边界滚动异常问题 Sep 3, 2022
@uyarn
Copy link
Collaborator

uyarn commented Sep 3, 2022

@HelKyle common Pull Request Tencent/tdesign-common#802 has been merged

@HelKyle
Copy link
Contributor Author

HelKyle commented Sep 3, 2022

@HelKyle common Pull Request Tencent/tdesign-common#802 has been merged

重新提了 pr #1426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TimePicker] 在chromium下使用touchpad滚动到边界效果异常
3 participants