Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimePicker): 修复边界滚动异常问题 #1426

Merged
merged 7 commits into from
Sep 3, 2022

Conversation

HelKyle
Copy link
Contributor

@HelKyle HelKyle commented Sep 3, 2022

fix: Tencent/tdesign-vue-next#1012

关联子仓库:Tencent/tdesign-common#802

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(TimePicker): 修复边界滚动异常问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #1426 (c9121ae) into develop (8a9ef3a) will increase coverage by 1.86%.
The diff coverage is 49.33%.

@@             Coverage Diff             @@
##           develop    #1426      +/-   ##
===========================================
+ Coverage    61.00%   62.86%   +1.86%     
===========================================
  Files         1030     1030              
  Lines        17933    17904      -29     
  Branches      4121     4089      -32     
===========================================
+ Hits         10940    11256     +316     
+ Misses        6993     6648     -345     
Impacted Files Coverage Δ
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) ⬇️
src/collapse/_usage/index.jsx 0.00% <0.00%> (ø)
src/config-provider/_example/global.jsx 100.00% <ø> (ø)
src/date-picker/DatePicker.tsx 14.66% <ø> (ø)
src/date-picker/DatePickerPanel.tsx 12.90% <ø> (ø)
src/date-picker/DateRangePicker.tsx 10.00% <ø> (ø)
src/date-picker/DateRangePickerPanel.tsx 10.29% <0.00%> (-0.08%) ⬇️
src/date-picker/_example/panel.jsx 33.33% <0.00%> (-16.67%) ⬇️
src/date-picker/base/Header.tsx 42.66% <0.00%> (-1.17%) ⬇️
src/date-picker/base/Table.tsx 60.52% <ø> (ø)
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

完成

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit 306d512 into Tencent:develop Sep 3, 2022
@uyarn uyarn changed the title fix: 修复 time-picker 边界滚动异常问题 fix(TimePicker): 修复边界滚动异常问题 Sep 3, 2022
@uyarn
Copy link
Collaborator

uyarn commented Sep 3, 2022

@HelKyle 刚刚只顾着看边界了 发现这个改动会引入其他问题

  1. 十二小时制的切换失效

image

2. 可输入的交互发生了异常

image

3. 通过其他按钮改动时间没有触发panel的正常滚动

image

辛苦再修复这两个引入的异常再提交PR

uyarn added a commit that referenced this pull request Sep 3, 2022
uyarn added a commit that referenced this pull request Sep 3, 2022
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TimePicker] 在chromium下使用touchpad滚动到边界效果异常
3 participants