Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with new GoogleMutant plugin #10

Open
seyfro opened this issue Feb 21, 2017 · 3 comments
Open

Issues with new GoogleMutant plugin #10

seyfro opened this issue Feb 21, 2017 · 3 comments

Comments

@seyfro
Copy link

seyfro commented Feb 21, 2017

Thanks for providing this leaflet plugin which is a really great improvement! Anyway we discovered some issues with the new Google leaflet plugin GoogleMutant
(https://gitlab.com/IvanSanchez/Leaflet.GridLayer.GoogleMutant/) - tiles are missing on basemap change (eg from OSM to Google Roadmap) if the option edgeBufferTiles is not explicitly set to 0 for GoogleMutant basemaps. Perhaps this could be added to the readme so that other users do not run into the same issue (which took us quite a while to figure out ;-)

Anyway as the edgeBuffer does not work for GoogleMutant in the first run (due to the way tiles are loaded via GoogleMutant), it would be great in the long run if EdgeBuffer support could also be added for GoogleMutant basemaps. We tried to figure out how to best achieve this, but did not succeed here yet - so any help would be much appreciated!

@seyfro
Copy link
Author

seyfro commented Feb 22, 2017

@TolonUK FYI - please see the comment from Ivan on how to add EdgeBuffer support to GoogleMutant at https://gitlab.com/IvanSanchez/Leaflet.GridLayer.GoogleMutant/issues/27#note_23940563 - this does not work yet though - we tried as you can see in the following comment, it only worked if edgeBufferTiles was set to 1. Any help here would be appreciated!

@TolonUK
Copy link
Owner

TolonUK commented Feb 23, 2017

@robertharm Thanks for bringing this to my attention, I'll make the documentation update as you suggest.

I've got a fix for the missing tiles problem, as per https://gitlab.com/IvanSanchez/Leaflet.GridLayer.GoogleMutant/issues/27#note_24035411, but that still doesn't make the edgebuffer functionality work as it should. I'll investigate this further based on the suggestion from @IvanSanchez.

@seyfro
Copy link
Author

seyfro commented Feb 23, 2017

@TolonUK you´re welcome. we did some further tests and it seems GoogleMutant is not working with EdgeBuffer even if we follow the approach from Ivan in # 27 - so therefore we decided to disable EdgeBuffer for GoogleMutant basemaps for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants